Righto.  This item dates back to when I didn't know how to include links in the xml content.  Will change.
d.

----------------------------------------
From: "Marco Tullney" <notifications@github.com>
Sent: Wednesday, August 14, 2013 11:00 AM
To: "pkp/ojs" <ojs@noreply.github.com>
Cc: "Damion Dooley" <damion@learningpoint.ca>
Subject: Re: [ojs] XML plugin -- corrections made (#92)

In plugins/xmlMarkup/settingsForm.tpl: 

> +					<a href="{$cssFolder}article_wide.css" target="_blank">article_wide.css</a><br/> > +					 > +					<br clear="all" /> > +					<br clear="all" /> > +				</td> > +			</tr> > +		 > +			<tr valign="top"> > +				<td width="35%" class="label" align="right"> > +					{fieldLabel name="cssHeaderImage" key="plugins.generic.markup.settings.cssHeaderImageURL"} > +				</td> > +				<td width="65%" class="value"> > +					<a href="{$cssFolder}{$cssHeaderImageName}" target="_blank">{$cssHeaderImageName}</a> <br/> > +					<input type="file" name="cssHeaderImage" /><br/> > +					{translate key="plugins.generic.markup.settings.cssHeaderImageURLHelp"}  > +					<a href="{url page="manager" op="files"}/css" target="_blank">{fieldLabel key="plugins.generic.markup.settings.cssFileManager"}</a>  

Why do you keep the URL out of the locale key? I know, it's hard coded and should not change, but this makes things more difficult for translations. Other languages might have a different word order, and by dividing the string into (locale key).(hard coded URL).(locale key) we lose flexibility. There are lots of examples in the OJS code where links are part of the locale key, so I think it might be wise to change this accordingly (see keys plugins.generic.markup.settings.cssHeaderImageURLHelp and plugins.generic.markup.settings.cssStylesHelp).  

-
Reply to this email directly or view it on GitHub.