On Tue, Apr 9, 2013 at 2:29 PM, Victor Julien <notifications@github.com>wrote:

> In src/app-layer-protos.h:
>
> > @@ -24,7 +24,7 @@
> >  #ifndef __APP_LAYER_PROTOS_H__
> >  #define __APP_LAYER_PROTOS_H__
> >
> > -enum {
> > +typedef enum AppProto {
>
> I was thinking about not typedeffing this as then it's clear it's an enum.
> Right now in the naming we typedef several types (int, struct, enum) which
> can be confusing. What do you think?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/inliniac/suricata/pull/340/files#r3709792>
> .
>
I'm okay with both.

-- 
Anoop Saldanha