added todo about shop parameter