I did not knew that


On Thu, Apr 11, 2013 at 1:28 PM, Manuel Laflamme
<notifications@github.com>wrote:

> In
> nrv-core/src/main/scala/com/wajam/nrv/consistency/replication/ReplicationPublisher.scala:
>
> > +
> > +    case class Unsubscribe(message: InMessage)
> > +
> > +    case class Error(subscription: SubscriptionActor, exception: Option[Exception] = None)
> > +
> > +    object Kill
> > +
> > +  }
> > +
> > +  class SubscriptionManagerActor extends Actor {
> > +
> > +    private lazy val subscribeMeter = metrics.meter("subscribe", "subscribe", serviceScope)
> > +    private lazy val subscribeErrorMeter = metrics.meter("subscribe-error", "subscribe-error", serviceScope)
> > +
> > +    private lazy val unsubscribeMeter = metrics.meter("unsubscribe", "subscribe", serviceScope)
> > +    private lazy val unsubscribeErrorMeter = metrics.meter("unsubscribe-error", "subscribe-error", serviceScope)
>
> AFAIK, we always use lazy meters so they do not appears in Scribe/MBean
> client until actually incremented. With a quick glance you can know there
> are no "subscribe-error" if the meters does not exist in the MBean client.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/wajam/nrv/pull/134/files#r3757576>
> .
>