edit view working fine