Fix synchronization of removeTrustWithoutCommit(OwnIdentity truster, Identity trustee):
- This is a caller of removeTrustWithoutCommit(Trust trust). Therefore it has to constrain to its synchronization requirements
- Synchronizing on the WOT doesn't make any sense here as well as the caller will have to do different stuff on the WOT and synchronize on it anyway.
- The following commits will deal with its callers
Indent.
Fix synchronization of removeTrust(OwnIdentity truster, Identity trustee):
- This is a caller of removeTrustWithoutCommit(OwnIdentity truster, Identity trustee). Therefore it has to constrain to its synchronization requirements
- The following commits will deal with its callers
Fix dangerous synchronization of removeTrust(OwnIdentity truster, Identity trustee) by inlining it into its only caller:
- The function did not have any synchronization requirements documented and did seem to be fully synchronized. However, if the OwnIdentity/Identity parameter objects were deleted between their obtaining and the calling of the function, it would lead to them being accidentally stored in the database again.