Completely agree with you here. Better to have it unexported and expose it later than to regret exporting it in the first place. My rule of thumb is that if it is too hard to explain in the Godoc comment then it needs to be rethought or not exported at all. :)

Sent from my iPhone

> On Nov 25, 2013, at 9:23 AM, Tom Bruggeman <notifications@github.com> wrote:
> 
> In acceptlang/handler.go:
> 
> > +import (
> > +	"bytes"
> > +	"fmt"
> > +	"github.com/codegangsta/martini"
> > +	"net/http"
> > +	"sort"
> > +	"strconv"
> > +	"strings"
> > +)
> > +
> > +const (
> > +	ACCEPT_LANGUAGE_HEADER = "Accept-Language"
> > +)
> > +
> > +// A single language from the Accept-Language HTTP header.
> > +type AcceptLanguage struct {
> @codegangsta in your opinion; would it not be better to not expose the ACCEPT_LANGUAGE_HEADER constant at all here?
> 
> It's really only for internal use, and might be confusing for users who may already have some constants defined for HTTP headers. It seems like a bad idea for 3rd party handlers to expose more than what they strictly need to.
> 
> —
> Reply to this email directly or view it on GitHub.