Hi Linas,

 

Thanks for looking into the script!

 

Just to be sure though, doesn’t your build folder then qualify as an ‘in-source’ build? It was my impression that we were trying to move away from ‘in-source’ builds, so this script was intended for people who run the ocpkg script in the new sudo-free way which creates an ‘out-of-source’ build folder.

 

To avoid confusion, ocpkg makes

 

Opencog

Opencog/src  ß gitroot in my script, since that’s where .git lives

Opencog/build

 

Take care,

 

Alex

 

 

From: Linas Vepstas [mailto:notifications@github.com] 
Sent: 07 March 2013 05:16
To: opencog/opencog
Cc: Alex van der Peet
Subject: Re: [opencog] SymLink script to support new ocpkg folder structure (#116)

 

In scripts/createSymLinksOCPKG.sh:

> +            mkdir -p bin/opencog/cython
> +            mkdir -p bin/opencog/embodiment/AtomSpaceExtensions/
> +
> +            echo "Folder creation complete!"
> +
> +            # And then the symbolic links
> +            # BUILDROOT = /tmp/opencog/build
> +            # ln -s ../../../../build/opencog/server/cogserver bin/opencog/server/cogserver
> +
> +            #echo "GITROOT=$GITROOT"                      
> +
> +            if [ -z $BUILDROOT ]; then
> +                    BUILDROOT=$GITROOT/../build
> +            fi 
> +
> +            if ! [ -e $BUILDROOT ]; then

I think this all looks pretty good, although here, perhaps you want to try to see if $GITROOT/build exists, and use that?

I'm not sure, maybe that is a bad idea, but that is where my build dir is. ...

—
Reply to this email directly or view it on GitHub <https://github.com/opencog/opencog/pull/116/files#r3269707> .  <https://github.com/notifications/beacon/Lo02E8G8QZK2yjRuF5xNm0gMivnRNDeGMWcYh-8kw3CWJRnUSCHPlCLA74kH4HMT.gif> 

  _____  

No virus found in this message.
Checked by AVG - www.avg.com
Version: 2013.0.2899 / Virus Database: 2641/6152 - Release Date: 03/06/13