Introduce RenderedJobTemplates

Knows how to cleanup stale templates associated with a DeploymentPlan::Instance

[#60724646]

Signed-off-by: Jeffrey Peckham <peckham@pivotallabs.com>
formatting

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
renamed RenderedJobTemplates to RenderedJobTemplatesCleaner

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
delete stale rendered job templates after apply state to instances

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
use instance model with RenderedJobTemplatesCleaner

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
make sure that RenderedJobTemplatesCleaner works when there are no template archives

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
clean all rendered job templates for specific instance when instance is deleted

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
replaced be_true/be_false with be(true)/be(false) in preparation for rspec3 upgrade

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
removed "..).with do" from specs in favor of "...) do"

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
Fix isntance_double constant name for rendered job template

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
added rspec-instafail

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
fix CompiledPackage stubs

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
use symbol method names when stubbing

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
fix BlobstoreClient specs

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
use proper Bosh::Stemcell classes for stubbing

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
prepare bosh-dev specs for rspec3

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
replace mock() and stub() with double()

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
stop using have() matcher with rspec

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
use stub_chain(..).and_return

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>
small spec fixes in preparation for rspec3

Signed-off-by: dmitriy kalinin <dmitriy@pivotallabs.com>