Unused parameter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48084 f5534014-38df-0310-8fa8-9805f1628bb7
Followup to r48081: use the DEFAULT_CAPTURE_BUFFER_SIZE macro from r47942.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48085 f5534014-38df-0310-8fa8-9805f1628bb7
Use consistent indentation (4 spaces);
Reformat  long single line comments for readability;
Add editor modelines.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48086 f5534014-38df-0310-8fa8-9805f1628bb7
From Joseph Chai:
Add aditional IE dissection.
From me patch cleanup and add set fence for multiple DTAP messages in one frame.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48087 f5534014-38df-0310-8fa8-9805f1628bb7
Use explicit casts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48088 f5534014-38df-0310-8fa8-9805f1628bb7
"HKEY_CURRENT_USER\Software\The Wireshark developer community, http://www.wireshark.org/\Wireshark\WinSparkle" isn't the prettiest registry path.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48089 f5534014-38df-0310-8fa8-9805f1628bb7
Fix some variable names to better indicate what they do.

Fix indentation.

Fix a proto_tree_add_uint_format_value() call not to include the name of
the field - proto_tree_add_uint_format_value() will add that for you.

Have dte_address_util() take the offset of the address as an argument;
it's not always at the same offset from the beginning of the facility.

Have it return the pointer to the generated string directly, rather than
through a pointer argument.

Create only one subtree for each facility, and give it a text description
of the facility code rather than the numerical value of the facility
code.  Make the top-level item for the facility cover all the bytes of
the facility, including code, length if present, and parameters.

Dissect the end-to-end transit delay and priorities facilities
completely.  Also, fix an incorrect use of "transmit delay" to say
"transit delay".

Get rid of the last of the spaces preceding colons in "Field: value"
descriptions and in a "default:" case label.

Do the data vs. non-data packet thing ith

	if (PACKET_IS_DATA(pkt_type)) {
		...
	} else {
		...
	}

rather than, in effect, doing the "else" with a break; that makes the
code a bit clearer.

Put the logical channel number into the protocol tree in common code for
the default case, rather than doing it separately for data and non-data
packets.  Clean up the dissection of non-data packets to add entries
before updating the columns, so that we don't throw an exception
updating the columns before we get to add items that wouldn't throw
exceptions.  Clear the Info column early in the dissection, in case we
throw an exception before getting to set it and thus leave behind the
column information for the protocol atop which we're running.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48093 f5534014-38df-0310-8fa8-9805f1628bb7
fix
packet-bssgp.c: In function 'de_bssgp_unconfim_send_state_var':
packet-bssgp.c:3318:13: error: variable 'state_var' set but not used [-Werror=unused-but-set-variable]



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48095 f5534014-38df-0310-8fa8-9805f1628bb7
it seems that g_free() needs a gpointer

using a gconstpointer creates a warning
capture_sync.c: In function ‘sync_pipe_open_command’:
capture_sync.c:823:13: error: passing argument 1 of ‘g_free’ discards ‘const’ qualifier from pointer target type [-Werror]


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48096 f5534014-38df-0310-8fa8-9805f1628bb7
Use XDLC_IS_INFORMATION() to determine whether there's a payload to hand
to the X.25 dissector or not.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48097 f5534014-38df-0310-8fa8-9805f1628bb7
Move the install_desktop_files target so it's not in the middle of the various package-making targets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48103 f5534014-38df-0310-8fa8-9805f1628bb7
Don't have a separate srpm-package target: we already build the SRPM while building the RPM (since r47574).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48105 f5534014-38df-0310-8fa8-9805f1628bb7
Remove a comment left over from the "old days".

Also: Add an XXX comment re one effect of the
      fact that, on Windows, dlg_window_new() does *not*
      set the newly created dialog window as 'transient for'
      the Wireshark top_level window.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48106 f5534014-38df-0310-8fa8-9805f1628bb7
Use explicit casts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48108 f5534014-38df-0310-8fa8-9805f1628bb7
Update the information on building RPMs based on recent work.  Include the information that the Qt development package needs to be installed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48109 f5534014-38df-0310-8fa8-9805f1628bb7
Don't say "Warn!", say "Warning!"


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48110 f5534014-38df-0310-8fa8-9805f1628bb7
Make the GTP and GTP' dissectors new-style dissectors, so that they can
reject packets that don't look enough like GTP/GTP' packets.  This fixes
bug 1706, and fixes some other cases where non-GTP/GTP' packets are
being dissected as GTP/GTP'.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48118 f5534014-38df-0310-8fa8-9805f1628bb7
From Peter Hatina: Fix for:  Gtk3 widgets are not properly expanded.
(Part of suggested patch for WIreshark 1.8 applied to trunk instead)

See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8315

From me: Add an XXX xomment about how, on Windows, closing the top_level
Wireshark window while the capture_interfaces dialog window is open
will leave the associated dumpcap process running.



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48122 f5534014-38df-0310-8fa8-9805f1628bb7
Followup to r48011, answering my own XXX comment:

No, ReportedBoundsError is not the right thing to throw, ReassemblyError is.
That's why I added it in the first place!


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48123 f5534014-38df-0310-8fa8-9805f1628bb7
Fix the plurality of the length of a data source if it has only 1 byte (I'm
looking at a "Bitstring tvb" that is only 1 byte long).


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@48127 f5534014-38df-0310-8fa8-9805f1628bb7