Sorry, I left this in the hope someone else commented.  I don't know what we consider best practices.  I'm barely competent at rspec to make those kinds of decisions.  I vote we just merge as-is for now and revisit once we've nailed that down.  We're going to start writing docs around testing very shortly so all these things will come up and decisions will be made so that we have something sensible to work from. :)