commited with 2 test cases