made ``ParameterCollection`` immutable... but actually, that is on setitem
so it should still work


On Mon, Aug 12, 2013 at 1:54 PM, Jai Ram Rideout
<notifications@github.com>wrote:

> In pyqi/core/command.py:
>
> > @@ -75,13 +77,21 @@ def _pythonize(self, name):
> >  class ParameterCollection(dict):
> >      """A collection of parameters with dict like lookup"""
> >      def __init__(self, Parameters):
> > -        self.Parameters = Parameters
> > -
> > -        for p in self.Parameters:
> > -            self[p.Name] = p
> > +        # populate the internal dict
> > +        super(ParameterCollection, self).__init__([(p.Name, p) for p in Parameters])
> > +
> > +        # store the Parameters for direct access
> > +        self.__dict__['Parameters'] = Parameters
>
> Why not just have self.Parameters = Parameters here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bipy/pyqi/pull/125/files#r5719566>
> .
>