Revert 196626 "DevTools: list devices above Chrome pages under c..."

Change was unreviewed by OWNERS.

> DevTools: list devices above Chrome pages under chrome://inspect.
> 
> TBR=jhawkins for minor webui tweak.
> 
> Review URL: https://codereview.chromium.org/13863018

TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/14571002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197195 0039d316-1c4b-4281-b951-d872f2087c98
Revert 197147 "Deeper histogram for SQLITE_IOERR."

> Deeper histogram for SQLITE_IOERR.
> 
> Sqlite.Error records the basic SQLite error codes.  Most of the
> extended codes are under SQLITE_IOERR, add a new histogram to record
> those.
> 
> BUG=none
> 
> Review URL: https://chromiumcodereview.appspot.com/14439007

TBR=shess@chromium.org

Review URL: https://codereview.chromium.org/14555006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197196 0039d316-1c4b-4281-b951-d872f2087c98
C++ readability review for dalecurtis.

AudioConverter is a tool for mixing and converting audio data from
one format to another; differences may include sample rates, channel
layout, and buffer size.

AudioConverter is the work horse behind several Chrome features:
- Allows mixing and conversion of HTML5 audio streams for thread savings:
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/audio_renderer_mixer.cc

- Allows Pepper clients (like Flash) to be oblivious of hardware requirements:
https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/audio_output_resampler.cc

- Tab Audio Mirroring:
https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/virtual_audio_input_stream.cc

Original CL for context: https://codereview.chromium.org/11410012/

R=fischman@chromium.org, lmendes@google.com

Review URL: https://codereview.chromium.org/12670011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197197 0039d316-1c4b-4281-b951-d872f2087c98
Reorder pieces of code.  No other changes.

* Make overriding functions as private as possible
* Make declaration order match definition order
* Fix a few other problems with section order not following the style guide
* For consistency, list functions in order: virtuals, non-virtuals, macro-based declarations
* In a few .cc files, try to keep class declarations and definitions together
* In a few .cc files, move enums into the classes the use them

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/14383022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197198 0039d316-1c4b-4281-b951-d872f2087c98
Fix cycling of focusable panes in Chrome OS.

Update the ash window cycle controller so it can tell aura::Window to rotate
pane focus and pass it the cycle direction, rather than just activating each
window. The end result is that when you press Ctrl+Back and Ctrl+Forward
you get a consistent cycle now, going through all panes within the most
recently active browser window and then the launcher and status area.

BUG=154598

Review URL: https://chromiumcodereview.appspot.com/13861032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197199 0039d316-1c4b-4281-b951-d872f2087c98
net: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST.

It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details.

BUG=234765
R=rch@chromium.org

Review URL: https://codereview.chromium.org/14113037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197200 0039d316-1c4b-4281-b951-d872f2087c98
Basic multi-module support

Allows resource export from one extension that can
be imported into another extension's namespace.


BUG=236044
TEST=browser_tests ExtensionApiTest.SharedModule
TEST=unit_tests SharedModuleManifestTest.*

Review URL: https://chromiumcodereview.appspot.com/13971005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197201 0039d316-1c4b-4281-b951-d872f2087c98
apps: Use base::MessageLoop.

BUG=236029
R=asargent@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14061020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197202 0039d316-1c4b-4281-b951-d872f2087c98
Forward guest console message to embedder through events.

BUG=233382
TEST=Added browser_tests

Review URL: https://chromiumcodereview.appspot.com/14098010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197203 0039d316-1c4b-4281-b951-d872f2087c98
webkit: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST.

It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details.

BUG=234765
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/14307012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197204 0039d316-1c4b-4281-b951-d872f2087c98
ppapi: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST.

It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details.

NOTE: This doesn't address PP_ALLOW_THIS_IN_INITIALIZER_LIST.

BUG=234765
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/14307011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197205 0039d316-1c4b-4281-b951-d872f2087c98
content: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST.

It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details.

BUG=234765
R=jam@chromium.org

Review URL: https://codereview.chromium.org/14386012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197206 0039d316-1c4b-4281-b951-d872f2087c98
apps: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST.

It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details.

BUG=234765
R=jeremya@chromium.org

Review URL: https://codereview.chromium.org/14511002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197207 0039d316-1c4b-4281-b951-d872f2087c98
Use base::TimeTicks instead of base::Time to resolve flaky tests using local_test_server_posix.cc.

BUG=230125
TBR=akalin

Review URL: https://chromiumcodereview.appspot.com/13890022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197208 0039d316-1c4b-4281-b951-d872f2087c98
Put enabling of tab audio notifications behind a command-line switch.

With this change, the tab audio output indicator (i.e., favicon animation) will be off by default for M28.  New goal is M29 (for UI improvements).

BUG=178934

Review URL: https://chromiumcodereview.appspot.com/14001013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197209 0039d316-1c4b-4281-b951-d872f2087c98
Finished implementing AttestationPolicyObserver.

Created a payload protobuf to track whether a key's certificate has
already been uploaded.

BUG=chromium:219959
TEST=unit

Review URL: https://chromiumcodereview.appspot.com/14220003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197210 0039d316-1c4b-4281-b951-d872f2087c98
Clarify that ClientCertStoreImpl::SelectClientCerts is testing-only

Rename SelectClientCerts to SelectClientCertsForTesting, indicating that its
a testing only function (matching the comments). Also switch the unittests to
use a fixture, to avoid FRIEND_TEST_ALL_PREFIXES growth

BUG=none
R=wtc

Review URL: https://chromiumcodereview.appspot.com/14254003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197211 0039d316-1c4b-4281-b951-d872f2087c98
Revert 197194 "<webview>: Fix redirect from about:blank"

> <webview>: Fix redirect from about:blank
> 
> Some sites replace default link behavior with the following snippet:
> 
> function open(href) {
>   var w = window.open('', '_blank');
>   w.opener = null;
>   w.document.write('<META HTTP-EQUIV="refresh" content="0; url=' +
>                   href + '">');
>   w.document.close();
> }
> 
> The subsequent navigation fails because it's delegated to the browser
> process, and the New Window API is not expecting browser-side navigation
> prior to attachment.
> 
> This patch delays all pre-attachment navigations until attachment.
> 
> BUG=233475, 222618
> Test=WebViewInteractiveTest.NewWindow
> 
> Review URL: https://chromiumcodereview.appspot.com/13837005

The WebViewInteractiveTest.NewWindow is failing on Mac bots.
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/14561004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197212 0039d316-1c4b-4281-b951-d872f2087c98
Changes Autocheckout Bubble messaging based on Google logged in status.


BUG= 228954

Review URL: https://chromiumcodereview.appspot.com/13686013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197213 0039d316-1c4b-4281-b951-d872f2087c98
Detect when chrome is shutting down and don't SendFinacialPing

BUG=160810

Review URL: https://chromiumcodereview.appspot.com/13868016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197214 0039d316-1c4b-4281-b951-d872f2087c98