Sending a PR to constantize the job label.

On Sat, Apr 13, 2013 at 3:48 PM, Matt T. Proud <notifications@github.com>wrote:

> In web/api/targets.go:
>
> > @@ -33,7 +33,9 @@ func (serv MetricsService) SetTargets(targetGroups []TargetGroup, jobName string
> >  		newTargets := []retrieval.Target{}
> >  		for _, targetGroup := range targetGroups {
> >  			// Do mandatory map type conversion due to Go shortcomings.
> > -			baseLabels := model.LabelSet{}
> > +			baseLabels := model.LabelSet{
> > +				model.LabelName("job"): model.LabelValue(job.Name),
>
> IIRC: "job": model.LabelValue(job.Name) would have worked just fine if
> providing the literal.
>
> Also: Constantization would be nice.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/prometheus/prometheus/pull/134/files#r3783654>
> .
>