correct format for attributes
correct format for attributes
added test