Before it just skipped the check when the watcher had opt_getselfemail
enabled, which was... I don't know. It seemed weird. More cases when it
was on?





On Mon, Nov 25, 2013, at 06:38 PM, Andrea Nall wrote:

  In cgi-bin/LJ/Event/JournalNewComment.pm:
> @@ -521,6 +517,24 @@ sub matches_filter {
>      return 0;
>  }
>
> +sub apply_noemail {
> +    my ( $self, $watcher, $comment, $method ) = @_;
> +
> +    my $entry = $comment->entry;
> +
> +    # not a match if this user posted the entry and they don't want comments
emailed,
> +    # unless it is a reply to one of their comments or they posted the commen
t
> +    my $reply_to_own_comment = $comment->parent ? $watcher->equals( $comment-
>parent->poster ) : 0;
> +    my $receive_own_comment = $comment->posterid == $watcher->id # we posted
> +                                && $watcher->prop( 'opt_getselfemail' ) && $w
atcher->can_get_self_email;

  ex: they may get their own comment when replying to a thread they
  have tracked, or when replying to a comment of theirs. I don't think
  they will always get their own comments, however. -- and IDK how
  this was handled previously but yes

  —

Reply to this email directly or [1]view it on GitHub.
[s73wEcta2S1lwypNIM0B_nwa6sFaBNupQcybWPKpjXXIH8vXfZFQYFlLPzJD5dRq.gif]

References

1. https://github.com/dreamwidth/dw-free/pull/615/files#r7913776