Well, i've tried various combinations of the "distributeOptions" member in the past. Don't think i've succeeded in doing something more useful than that there. Basically, i am having problems understanding what exactly we declare there. Let's take for instance the cursor size adjuster which wants to apply preview only to itself so it serves the "emptyComponentType" to others,

https://github.com/chrispetsos/prefsEditors/blob/master/src/shared/adjusters/js/CursorSizeAdjuster.js#L50-L62

What do those "textSize" and "magnifier" stand for? Are they components? Do they take their name from here?

https://github.com/chrispetsos/prefsEditors/blob/master/src/pmt/js/PMTUIOSchema.js#L91-L109

Since now we have a single "increaseSize" component which merges all those, will those "distributeOptions" blocks behave the same? I am also mentioning that, currently, previewing works as expected until a Save/Reset/Cancel. After that we need a page reload (can you confirm?). The thing is that i do not know exactly why and how this all works, i had to comment out the "removeSource: true" declarations for things to work...

Date: Fri, 25 Oct 2013 07:34:55 -0700
From: notifications@github.com
To: prefsEditors@noreply.github.com
CC: chrispetsos@msn.com
Subject: Re: [prefsEditors] GPII-187, GPII-188, GPII-225, GPII-227 contributions (#7)

In src/pmt/js/PMT.js:

> +                },
> +                resetButtonText: {
> +                    expander: {
> +                        func: "gpii.uiOptions.pmt.lookupMsg",
> +                        args: ["{uiOptionsLoader}.msgBundle", "resetButtonText"]
> +                    }
> +                },
> +                cancelButtonText: {
> +                    expander: {
> +                        func: "gpii.uiOptions.pmt.lookupMsg",
> +                        args: ["{uiOptionsLoader}.msgBundle", "cancelButtonText"]
> +                    }
> +                }
> +            },
> +            components: {
> +                increaseSizeExtraAdjustersComponent: {

It looks like the distribute options are being merged. I suppose that they could be incorrectly setup, so you should double check that.


I did some more digging. What I'm getting is a bit strange. So it seems the reason things look broken is the function gpii.uiOptions.enactors.cursorSize.set can't find the cursorDiv. What's really strange, is that the container for this specific preview appears to be on the Magnification preview instead of the Cursor Size preview. You should double check that when you save that something strange isn't happening with the containers for the components and subcomponents. 


—
Reply to this email directly or view it on GitHub.