well if it fails anyhow the assert is not required; decide what you want to
test/assert and then ONLY assert that; the rest is execution/setup


On Mon, Mar 25, 2013 at 11:49 AM, François Thillen <notifications@github.com
> wrote:

> In bridge/BridgeTests/TestDomainFactoryProvider.cs:
>
> > +            IDomainFactory factory = DomainFactoryProvider.GetDomainFactoryInstance<String>("3.0.0", null, null);
> > +            Assert.IsNotNull(factory);
> > +        }
> > +        [TestMethod]
> > +        public void TestFactory240OpenEngSBVersion()
> > +        {
> > +            IDomainFactory factory = DomainFactoryProvider.GetDomainFactoryInstance<String>("2.4.0", null, null);
> > +            Assert.IsNotNull(factory);
> > +        }
> > +        [TestMethod]
> > +        [ExpectedException(typeof(BridgeException))]
> > +        public void TestFactoryInvalidOpenEngSBVersion()
> > +        {
> > +            IDomainFactory factory = DomainFactoryProvider.GetDomainFactoryInstance<String>("1.4.0", null, null);
> > +            Assert.IsNull(factory);
> > +            factory = DomainFactoryProvider.GetDomainFactoryInstance<String>("Test", null, null);
>
> This assert is just to make sure that in the next step the exception will
> be thrown. If factory==null, the test case works wrong
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/48/files#r3509440>
> .
>