changes to attr params