(#21533) Verify facter doesn't write to stderr

This commit doesn't fix #21533, but it adds an acceptance test to detect
if executing `facter` writes to stdout.
Adding a windows fact for i686 to architecture specs
(#20989) x86 windows hardware model show i686 not i1586

Currently hardware model uses the cpu level when
using 32 bit windows on x64 capable hardware. The
actual architecture is i686 even though it might be
showing as i1586 if the cpu level is 15. 

Based on my research on this, all levels above 6 
should show the i686 hardware model. i1586 or i1186
would be a misnomer.

This fix adds a check to determine if the cpu level
is over 6 and then responds by setting the 
architecture_level (new) to 6, otherwise it uses the
cpu level coming back from the windows processor 
query.

Note this only affects windows hardware.
Don't build debuginfo rpm package

Prior to this commit, mock would spit out a debuginfo package on facter.
This is pointless as facter contains zero compiled code. It would be a
noarch package, save for some arch-specific dependencies. So, since I
can't fix that bug in RPM, I can make it so I don't have to remove the
debuginfo package every single time.

Signed-off-by: Michael Stahnke <stahnma@puppetlabs.com>
Merge pull request #473 from ferventcoder/ticket/master/20989-windows-x86-reported-wrong

(#20989) x86 windows hardware model show i686 not i1586
Adding a windows fact for i686 to architecture specs
(#20989) x86 windows hardware model show i686 not i1586

Currently hardware model uses the cpu level when
using 32 bit windows on x64 capable hardware. The
actual architecture is i686 even though it might be
showing as i1586 if the cpu level is 15.

Based on my research on this, all levels above 6
should show the i686 hardware model. i1586 or i1186
would be a misnomer.

This fix adds a check to determine if the cpu level
is over 6 and then responds by setting the
architecture_level (new) to 6, otherwise it uses the
cpu level coming back from the windows processor
query.

Note this only affects windows hardware.
Merge branch 'ticket/stable/20989-windows-x86-reported-wrong' into stable

* ticket/stable/20989-windows-x86-reported-wrong:
  (#20989) x86 windows hardware model show i686 not i1586
  Adding a windows fact for i686 to architecture specs
Merge remote-tracking branch 'upstream/stable'

* upstream/stable:
  (#20989) x86 windows hardware model show i686 not i1586
  Adding a windows fact for i686 to architecture specs
(packaging) Update FACTERVERSION to 1.7.2
Merge tag '1.7.2' into stable

1.7.2
Merge branch 'stable'
(maint) Fix mocha expectations crashing facter_spec

Running `bundle exec rspec spec/unit/util/virtual_spec.rb
spec/unit/facter_spec.rb` prior to this patch would crash rspec outright
while the test harness was still loading.  This was because
virtual_spec.rb had expectations set in a shared_examples block but
outside of a before or it block.  These then caused an expectation
failure when explicit calls to Facter[:foo] were used as the description
in two describe calls in facter_spec.

This patch clears up both those misuses of rspec, and also adds the
log_spec_order method from Puppet for future bisecting of spec order
issues in Facter...which hopefully we won't have to do. :)
(maint) Rakefile loads all the libraries it can.

The call to load ext/packaging/packaging.rake will fail unless the
packaging system has been bootstrapped.  Previously this failure would
prevent attempts to load other libraries (notably rspec), and a `be rake
spec` would return silently without executing any specs.

Requires each lib separately so that failure to load one does not
prevent others.
(maint) Update README with a little bit of spec info.
(#21533) Convert network data to string before access
Merge branch 'pull-468' into stable

This closes GH-468
Merge branch 'stable'
Merge pull request #474 from stahnma/dont_build_debuginfo_rpm

Don't build debuginfo rpm package
Merge pull request #475 from jpartlow/maint/stable/virtual_and_facter_spec_order_fix

Maint/stable/virtual and facter spec order fix