ASSERT should only be used when the test cannot continue. even though here it doesn't -need- to continue, out might change, and its consistent anyways

Richard Eyre <notifications@github.com> wrote:

>In test/unit/stringlist_unittest.cpp:
>
>> + > + ASSERT_EQ( 8, alloc() ); > + ASSERT_EQ( 0, length() ); > + ASSERT_STREQ( "This is a test.", webvtt_string_text( &str ) ); > + webvtt_release_string( &str ); > +} > + > +TEST_F(StringListTest, PushAndPop) > +{ > + push( "This is a test." ); > + pop(); > + push("Random new test."); > + > + EXPECT_EQ( 8, alloc() ); > + EXPECT_EQ( 1, length() ); > + ASSERT_STREQ( "Random new test.", stringAt( 0 ) ); 
>
>I don't see why that should be the case. Putting EXPECT here won't effect the execution of other tests in the set. 
>
>I thought we all agreed earlier that we should be using ASSERT where possible so as to not break execution of the tests, except in situations where a condition not being met will mean the failure of the rest of the conditions anyways.
>
>—
>Reply to this email directly or view it on GitHub.￼
>