CodeGeneratorJS doesn't generate header includes for sequence<type>
https://bugs.webkit.org/show_bug.cgi?id=121314

Reviewed by Dean Jackson.

* bindings/scripts/CodeGeneratorJS.pm:
(SkipIncludeHeader): Don't return false for sequence and array types.
(AddIncludesForType): Do add includes for sequence and array types.
(GenerateCallbackImplementation):
* bindings/scripts/test/JS/JSTestTypedefs.cpp: Regenerated
* bindings/scripts/test/JS/JSTestTypedefs.h: Ditto.
* bindings/scripts/test/TestTypedefs.idl: Add a method that takes a sequence<TestEventTarget>.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Mac] WebCore Web Inspector files are only copied as part of clean build
https://bugs.webkit.org/show_bug.cgi?id=121316

Reviewed by Timothy Hatcher.

Removed insufficient dependencies to make the phase run unconditionally.

* WebCore.xcodeproj/project.pbxproj:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Flaky Test: http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
https://bugs.webkit.org/show_bug.cgi?id=114209

Reviewed by Joseph Pecoraro.

* TestExpectations: Marked the test as WontFix. It is hopelessly broken, and
doesn't test anything specific anyway.

* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
Removed from the lists, as the test is now skipped globally.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Apply OVERRIDE and FINAL to Image subclasses and clean them up
https://bugs.webkit.org/show_bug.cgi?id=121086

Reviewed by Alexey Proskuryakov.

Everything other than the copious application of OVERRIDE and FINAL
is explicitly called out below.

* WebCore.exp.in:
Export the correct version of getCGImageRef for use by WebKit2.

* platform/graphics/BitmapImage.cpp:
* platform/graphics/BitmapImage.h:
Drive-by inline isBitmapImage.
Move create(HBITMAP) to be near the other create() functions.
Move all of the members private.
Devirtualize frameCount().
Move notSolidColor() near the other solid color functions.

* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
Use size() and setContainerSize() instead of directly accessing a
superclass' (now private, previously protected) members.

* platform/graphics/CrossfadeGeneratedImage.h:
* platform/graphics/GeneratedImage.h:
Make m_size private, I don't think we do protected members.

* platform/graphics/GeneratorGeneratedImage.h:
Make all the members private.

* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageForContainer.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed; part one of build fix for Windows.
Sorry for the noise, I thought I'd fixed it.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ContextMenuController should hold onto a Page&
https://bugs.webkit.org/show_bug.cgi?id=121320

Reviewed by Anders Carlsson.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController):
(WebCore::ContextMenuController::~ContextMenuController):
(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
(WebCore::ContextMenuController::showContextMenuAt):
* page/ContextMenuController.h:
Store the Page and ContextMenuClient as references.

* page/Page.cpp:
(WebCore::Page::Page):
Pass the Page and ContextMenuClient as references and switch to using createOwned<>().


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Try to kill initialiser expression in for-in statements
https://bugs.webkit.org/show_bug.cgi?id=121311

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

We'd like to get rid of this pointless initialiser expression
in for-in statements.  Unfortunately we have to keep the no_in
variant of expression parsing to avoid ambiguity in the grammar.
There's a possibility that this will need to be rolled out, but
we'll need to live on it to see.

* bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createForInLoop):
* parser/NodeConstructors.h:
(JSC::ForInNode::ForInNode):
* parser/Nodes.h:
* parser/Parser.cpp:
(JSC::::parseForStatement):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createForInLoop):

LayoutTests:

Update test cases to represent the new reality

* js/line-column-numbers-expected.txt:
* js/line-column-numbers.html:
* js/parser-syntax-check-expected.txt:
* js/script-tests/function-declaration-statement.js:
* js/script-tests/line-column-numbers.js:
(try.toFuzz22b):
* js/script-tests/parser-syntax-check.js:
* js/script-tests/toString-for-var-decl.js:
(f1):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Layout Test fast/dom/Window/window-postmessage-clone.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=111898

Reviewed by Oliver Hunt.

* fast/dom/Window/script-tests/postmessage-clone.js: The test was checking
modification times of non-existent files. When you do this, you get current time,
and current time changes over time, making comparisons non-reliable.

* fast/dom/Window/resources/file1.txt: Added.
* fast/dom/Window/resources/file2.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[mac WK1] Introduce WebViewWillCloseNotification
https://bugs.webkit.org/show_bug.cgi?id=121321

Reviewed by Sam Weinig.

* WebKit.exp: Exported WebViewWillCloseNotification.
* WebView/WebView.mm:
(-[WebView _close]): Send WebViewWillCloseNotification before closing the WebView.
* WebView/WebViewPrivate.h: Declared WebViewWillCloseNotification.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Flaky Test: svg/dom/SVGScriptElement/script-load-and-error-events.svg
https://bugs.webkit.org/show_bug.cgi?id=25817

Reviewed by Tim Horton.

* svg/dom/SVGScriptElement/script-load-and-error-events.svg: Made test output
a bit more verbose to see what's happening on bots.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155727 268f45cc-cd09-0410-ab3c-d52691b4dbfc