Sounds good. Let's change it to authorized.

Maybe you could also add a short doc comment.


On Thu, Sep 12, 2013 at 9:22 AM, Sven <notifications@github.com> wrote:

> In Plugin/PluginInterface.php:
>
> > @@ -38,6 +38,7 @@
> >      const REASON_CODE_INVALID = 'invalid';
> >      const REASON_CODE_SUCCESS = 'none';
> >      const REASON_CODE_TIMEOUT = 'timeout';
> > +    const REASON_CODE_AUTHORIZATION = 'authorization';
>
> Sure.
>
> Ok, we could change it to "authorized". "authorization" is just a paypal
> namining. From the docs:
> authorization – The payment is pending because it has been authorized but
> not settled. You must capture the funds first.
>
>    - So it is the case successfully authorized and ready to desposit.
>
> I agree to be more precise in this. But for now the (successfully)
> "authorized" state ist the only one we need to get know of to provide
> separate approve and deposit process as implemented f.e. in paypal plugin.
>
> If another payment provider case needs more specific cases we have to
> extend than later.
>
> Is this ok for you?
>
> I would change the wording.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/schmittjoh/JMSPaymentCoreBundle/pull/120/files#r6315028>
> .
>