add readme and fix upvalues