update attribs