I thought about that, but it doesn't seem to very well allow for modifying
the defaults at runtime unless I'm missing something.

It could be that I've never really grasped the 'params' pattern very well
(hiera sure, but params...not so much).

Now, in theory, the params could be a paramaterized class that allows for
setting the variables independently.

Then, init would pick them up whatever I set them to so long as I include
the class first.

However, it's not written as a parameterized class so, if I call logstash
with parameters, I end up breaking the link between logstash::params and
everything else.

So, I chose to use the solid link of logstash::<param>.

Did I miss the mark completely on usage? And example of how to properly do
overrides with the logstash module would be most welcome.

Thanks,

Trevor


On Mon, Sep 9, 2013 at 3:45 AM, Richard Pijnenburg <notifications@github.com
> wrote:

> In manifests/service.pp:
>
> > @@ -163,6 +163,15 @@
> >
> >      } else {
> >
> > +      file { "${logstash::defaults_location}/logstash":
>
> Hi,
>
> This should be "${logstash::params::defaults_location}/logstash":
> you are missing the 'params' part :-)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/logstash/puppet-logstash/pull/85/files#r6232161>
> .
>



-- 
Trevor Vaughan
Vice President, Onyx Point, Inc
(410) 541-6699
tvaughan@onyxpoint.com

-- This account not approved for unencrypted proprietary information --