Don't have strong feelings either way though, happy to just log once.


On Sat, Feb 9, 2013 at 11:15 PM, Patrick Wendell <pwendell@gmail.com> wrote:

> What this does is that it periodically prints a warning message until a
> slave joins the cluster, then they stop. I'd be fine to just have it print
> once, but I feel like it has more of an effect as a periodic message,
> because other messages may be printing out at the same time. For instance,
> if a bunch of jobs are being submitted, this would keep pinging with the
> warning until the user resolved the situation.
>
>
> On Sat, Feb 9, 2013 at 10:46 PM, Josh Rosen <notifications@github.com>wrote:
>
>> In core/src/main/scala/spark/scheduler/cluster/ClusterScheduler.scala:
>>
>> > @@ -94,6 +101,18 @@ private[spark] class ClusterScheduler(val sc: SparkContext)
>> >        activeTaskSets(taskSet.id) = manager
>> >        activeTaskSetsQueue += manager
>> >        taskSetTaskIds(taskSet.id) = new HashSet[Long]()
>> > +
>> > +      if (hasReceivedTask == false) {
>> > +        starvationTimer.scheduleAtFixedRate(new TimerTask() {
>>
>> Why is this scheduled periodically rather than only once (e.g. why did
>> you use Timer.scheduleAtFixedRate() instead of Timer.schedule())?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mesos/spark/pull/444/files#r2954573>..
>>
>>
>
>