Yup, stylistically I'd prefer to slap a few parentheses on it. Thanks!

--
Nathaniel


On Wed, May 22, 2013 at 2:04 PM, Chris Agerton <notifications@github.com>wrote:

> In lib/active_merchant/billing/gateways/blue_pay.rb:
>
> >            ].join("")
> >          )
> >        end
> >
> >        def handle_response(response)
> > -        if ignore_http_status
> > -          response.body
> > -        else
> > -          case response.code.to_i
> > -          when 200...300
> > -            response.body
> > -          else
> > -            raise ResponseError.new(response)
> > -          end
> > +        if ignore_http_status or (200...300).include? response.code.to_i
>
> This is a syntax error:
> false || ([]).include? ''
> This is not:
> false or ([]).include? ''
>
> But I can use '||' and add parens to 'include?(...)' if it's more
> consistent with the style here.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Shopify/active_merchant/pull/699/files#r4344856>
> .
>