I think that's just sliding code smell from one part to another part. The problem is that upload_cookbook_from() is just trying to do too much. I'll try breaking things out and seeing where it goes.