still working on attribute:value generation