Hm, I do… but sometimes I may overlook the output since it's not that in-your-face. Maybe I should stop producing code late at night.

From: Joel Brandt <notifications@github.com<mailto:notifications@github.com>>
Reply-To: adobe-photoshop/generator-assets <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Friday, July 12, 2013 2:46 PM
To: adobe-photoshop/generator-assets <generator-assets@noreply.github.com<mailto:generator-assets@noreply.github.com>>
Cc: Dennis Kehrig <dkehrig@adobe.com<mailto:dkehrig@adobe.com>>
Subject: Re: [generator-assets] Proper PNG-8 support, improved GIF support (#45)


In main.js:

>              args.push("-background", backgroundColor, "-flatten");
>          }
> -        if (format === "gif" || format === "png8") {
> -            args.push("-transparent", backgroundColor);
> +        if (format === "gif") {
> +            // Make it so that pixels that were <1% transparent before become fully transparent
> +            // while the other pixels have the same color as if seen against a white background
> +            // Create a copy of the original image, making it truly RGBA, and delete the ARGB original
> +            // Copy the image and flatten it, then apply the binary transparency of another copy
> +            // Afterwards, remove the RGBA image as well, leaving just one image
> +            args = args.concat(("( -clone 0 ) -delete 0 ( -clone 0 -background " + backgroundColor + " -flatten -clone 0 -channel A -threshold 99% -compose dst-in -composite ) -delete 0").split(/ /));


this line is too long. don't you run jshint?!

I'll fix it.

—
Reply to this email directly or view it on GitHub<https://github.com/adobe-photoshop/generator-assets/pull/45/files#r5175583>.