The only reason I left them there is that I wasn't sure whether the
multi-table outer join is going in at the same time. If so, the test case
and the temp restriction in the code definitely needs to be cleaned up


On Mon, Oct 14, 2013 at 4:32 PM, Paul A Martel <notifications@github.com>wrote:

> In tests/frontend/org/voltdb/planner/TestJoinOrder.java:
>
> > @@ -118,9 +118,9 @@ public void testInnerOuterJoinOrder() {
> >                      "T2, T6, T3, T4, T5, T7, T1");
> >              fail();
> >          } catch (Exception ex) {
> > -            assertTrue("VoltDB does not support outer joins with more than two tables involved".equals(ex.getMessage()));
> > +//            assertTrue("VoltDB does not support outer joins with more than two tables involved".equals(ex.getMessage()));
> >  //          @TODO ENG_3038 Commented out until 2 table restriction for outer joins is there
>
> This cleanup needs some cleanup. Remove dead code commetns. Remove
> no-longer-applicable comments.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/5/files#r6954717>
> .
>