Agree, need I commit a new patch, I think you can help squash this, thanks.



2013/10/18 Li Yang <notifications@github.com>

> In libvirt/tests/src/virsh_cmd/domain/virsh_emulatorpin.py:
>
> > +
> > +    cg = utils_cgroup.CgconfigService()
> > +
> > +    if cgconfig == "off":
> > +        if cg._service_cgconfig_control("status"):
> > +            cg.cgconfig_stop()
> > +
> > +    if status_error == "yes":
> > +        if change_parameters == "no":
> > +            get_emulatorpin_parameter(test_dicts)
> > +        else:
> > +            set_emulatorpin_parameter(test_dicts)
> > +
> > +    # Recover cgconfig and libvirtd service
> > +    if not cg._service_cgconfig_control("status"):
> > +        cg.cgconfig_start()
>
> Here I suggest to use cg.cgconfig_restart(), because although executed
> cg.cgconfig_stop() before, users still can create cgroup manually, at this
> time, execute cg.cgconfig_start() will fail, the environment cannot be
> recovered.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/autotest/virt-test/pull/583/files#r7053630>
> .
>