Yes I think it does, this is just a reminder to set those env variables.

Sent from my iPhone

On Jun 17, 2013, at 7:48 PM, "dhawt" <notifications@github.com<mailto:notifications@github.com>> wrote:


In README.md:

> @@ -66,6 +66,15 @@ Create a user:
>
>  ...start your rails server, and you can log in at 0.0.0.0:3000/flms/login.
>
> +Deployment on Heroku
> +---------------------
> +
> +If you did not add s3.yml to your project due to security concerns you need to add those credentials in Heroku so you can use S3.
> +
> +    $ heroku config:set S3_BUCKET=your_bucket_name
> +    $ heroku config:set S3_ACCESS_KEY=your_access_key_id
> +    $ heroku config:set S3_SECRET_KEY=your_secret_access_key
> +


Double check the logic on this - I believe in production it only looks at the heroku environment for S3 keys. We should probably fix that if that's the case.

—
Reply to this email directly or view it on GitHub<https://github.com/Originate/flms/pull/122/files#r4740254>.