Use super() to call base class methods

Such as __init__() and summary().

Signed-off-by: Andy Grover <agrover@redhat.com>
Add tag support

Tags allow initiator WWNs to be given shorter names, as well as multiple
WWNs to be managed as one unit. get() operations just get values from

Simplify auth- and discovery_auth-setting code.


Signed-off-by: Andy Grover <agrover@redhat.com>
Simplify tag()

tag() always takes a new_tag.

Signed-off-by: Andy Grover <agrover@redhat.com>
Better fileio checking for existing backstore.

See https://bugzilla.redhat.com/show_bug.cgi?id=915664

Signed-off-by: Andy Grover <agrover@redhat.com>
Next version is 2.0.fb20

Let's ditch the rc1 bit, it has no use.

Signed-off-by: Andy Grover <agrover@redhat.com>
Fix UINodeACL creation

UINodeACL expects the NodeACL wwn name, not the NodeACL itself.

Closes #18

Signed-off-by: Andy Grover <agrover@redhat.com>
Add error checking for tag()

Report an error if source wwn_or_tag is empty.

Signed-off-by: Andy Grover <agrover@redhat.com>
Next version is fb21

Signed-off-by: Andy Grover <agrover@redhat.com>
Fix params to UITarget.summary()

self passed implicitly.

Signed-off-by: Andy Grover <agrover@redhat.com>
Remove execute_command in UIRTSLibNode

extraneous.

Signed-off-by: Andy Grover <agrover@redhat.com>
Remove accidentally left-in print

From tag implementation.

Signed-off-by: Andy Grover <agrover@redhat.com>
Updating version string format and number

Packaging tools tend to miscalculate which version is higher when "fb" is
in the version. Switch to omitting "fb" from $EXTRAVERSION. git tags will
continue to have "fb".

Signed-off-by: Andy Grover <agrover@redhat.com>
Update version for proper pkg versioning

Unfortunately I made a mistake, and did not handle version with 'rc' in it
as specified here:

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

I'm incrementing the version to 2.1.<fb-ver> to get version sequencing
right. It's a little uncool for me to be mixing my developer and packager
roles here, but I think I can rationalize a version bump, given the
tag and WWN improvements recently.

Signed-off-by: Andy Grover <agrover@redhat.com>
Fix discovery auth

We really need a test suite to catch stupid stuff like this.

Signed-off-by: Andy Grover <agrover@redhat.com>
Use 'with ignored'

Woo, saved one line.

Signed-off-by: Andy Grover <agrover@redhat.com>
iSER support

Signed-off-by: Andy Grover <agrover@redhat.com>
Make 'info' command return dump() information

Implement info command for all UIRTSLibNodes.

Fixup UIFabricModule.info impl to not use spec dict.

Add subclass impl for UINodeACL, since it doesn't have self.rtsnode and
needs special handling.

Remove UINodeACL wwns cmd, since info does it now.

Signed-off-by: Andy Grover <agrover@redhat.com>
Don't print a decimal point if returning bytes

Fractions of bytes makes no sense.

Signed-off-by: Andy Grover <agrover@redhat.com>
Remove usage of is_disk_partition

Not a differentiator in whether we can use a block device as a backstore
or not.

Signed-off-by: Andy Grover <agrover@redhat.com>
Fix info print when using block device with fileio backstore

We need to get the size from the object, since block devs won't have
a passed-in value.

Signed-off-by: Andy Grover <agrover@redhat.com>