Ok, I think you convinced me, at least write the lambdas as `lambda iv,
**kwargs: ...` though.


On Fri, Dec 20, 2013 at 10:26 PM, Paul Kehrer <notifications@github.com>wrote:

> In tests/hazmat/primitives/utils.py:
>
> > @@ -44,8 +44,8 @@ def encrypt_test(backend, cipher_factory, mode_factory, params, only_if,
> >                   skip_message):
> >      if not only_if(backend):
> >          pytest.skip(skip_message)
> > -    plaintext = params.pop("plaintext")
> > -    ciphertext = params.pop("ciphertext")
> > +    plaintext = params["plaintext"]
>
> I don't think I agree since the ugliness was already present in each
> lambda (lambda key, iv: modes.CBC(binascii.unhexlify(iv)) is no better
> than lambda **kwargs: modes.CBC(binascii.unhexlify(kwargs["iv"]) IMO),
> but I don't feel strongly about it so I'll revert to a dict copy in the
> morning. :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/323/files#r8516642>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084