this code is screwed.  the first step is to remove the blatant errors.  It
will need more change than this PR, and I can only budget a couple hours
(already spent).  If you don't mind, lets keep the review to the changes I
made for now.


On Mon, Apr 8, 2013 at 8:08 PM, Andrew Phillips <notifications@github.com>wrote:

> In
> providers/aws-s3/src/main/java/org/jclouds/aws/s3/blobstore/strategy/internal/SequentialMultipartUploadStrategy.java:
>
> > +
> > +   private void prepareUploadPart(String container, String key, String uploadId, int part, Payload payload,
> > +         long offset, long size, SortedMap<Integer, String> etags) {
> > +      Payload chunkedPart = slicer.slice(payload, offset, size);
> > +      String eTag = null;
> > +      try {
> > +         eTag = client.uploadPart(container, key, part, uploadId, chunkedPart);
> > +         etags.put(Integer.valueOf(part), eTag);
> > +      } catch (KeyNotFoundException e) {
> > +         // note that because of eventual consistency, the upload id may not be
> > +         // present yet we may wish to add this condition to the retry handler
> > +
> > +         // we may also choose to implement ListParts and wait for the uploadId
> > +         // to become available there.
> > +         eTag = client.uploadPart(container, key, part, uploadId, chunkedPart);
> > +         etags.put(Integer.valueOf(part), eTag);
>
> Erm...so the idea his simply to retry once?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/1504/files#r3707053>
> .
>