Not only it would be unadvisable, but it would be most probably suicidal. I
think we can assume this value would be set for the duration of the
execution.

As for readability, I don't see this really being the case. Here I can see
how my data gets defined and what is the relation between bufferSize and
datasize in one block, whereas now it separate.

Please use a

```javascript
var datasize = this._dataSize;
```

reference instead.


On Tue, Sep 3, 2013 at 5:55 PM, Ron Korving <notifications@github.com>wrote:

> In graylog.js:
>
> >      this.hostname   = config.hostname || require('os').hostname();
> >      this.facility   = config.facility || 'Node.js';
> >
> >      this._callCount  = 0;
> >
> >      this._bufferSize = config.bufferSize || this.DEFAULT_BUFFERSIZE;
> > -    this._dataSize   = this._bufferSize - 12;
>
> True, but it's a single subtraction, there's no real point to stick that
> private variable on the object. Also, if someone changes bufferSize halfway
> through (not advisable, but not impossible), we have no way to update
> datasize. It also makes the code a tad more readable down below, because it
> won't use that or the underscore.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Wizcorp/node-graylog2/pull/1/files#r6120217>
> .
>



-- 
<http://www.wizcorp.jp/>Marc Trudel-Belisle
Chief Technology Officer | Wizcorp Inc. <http://www.wizcorp.jp/>
------------------------------
TECH . GAMING . OPEN-SOURCE WIZARDS+ 81
3-4550-1448|Website<http://www.wizcorp.jp/>
|Twitter <https://twitter.com/Wizcorp>|Facebook<http://www.facebook.com/Wizcorp>
|LinkedIn <http://www.linkedin.com/company/wizcorp>