Checked in and ready


On Thu, Sep 26, 2013 at 1:55 PM, Chris George <cgeorge@federatedmedia.net>wrote:

> I'll amend request... gimme few minutes to test
>
>
> On Thu, Sep 26, 2013 at 1:34 PM, P. Taylor Goetz <notifications@github.com
> > wrote:
>
>> In bin/storm:
>>
>> > @@ -29,7 +29,7 @@ if (not os.path.isfile(USER_CONF_DIR + "/storm.yaml")):
>> >      USER_CONF_DIR = CLUSTER_CONF_DIR
>> >  CONFIG_OPTS = []
>> >  CONFFILE = ""
>> > -JAR_JVM_OPTS = os.getenv('STORM_JAR_JVM_OPTS', '')
>> > +JAR_JVM_OPTS = os.getenv('STORM_JAR_JVM_OPTS' + " ", '')
>>
>> I can vouch for @xumingming <https://github.com/xumingming>'s approach.
>> Changing line 142 to this:
>>
>> jvmopts=[' '.join(filter(None, [JAR_JVM_OPTS, "-Dstorm.jar=" + jarfile]))])
>>
>> Fixed the issue for me.
>>
>> I'd prefer to have @roadkill001 <https://github.com/roadkill001> amend
>> the pull request and merge that, since @roadkill001<https://github.com/roadkill001>first discovered it and got the ball rolling for a fix.
>>
>> But if we feel it's urgent I can add a new pull request so we wouldn't
>> have to wait for a CLA.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/nathanmarz/storm/pull/683/files#r6611779>
>> .
>>
>
>