Right. Those are tests before your fix. I will need to update that.


On Wed, Jan 30, 2013 at 6:40 PM, James Taylor <notifications@github.com>wrote:

> In src/test/java/com/salesforce/phoenix/compile/QueryCompileTest.java:
>
> > +        List<Object> binds = Collections.emptyList();
> > +        Scan scan = new Scan();
> > +        compileQuery(query, binds, scan);
> > +        assertTrue(Bytes.compareTo(Bytes.toBytes("abc"), scan.getStartRow()) == 0);
> > +        assertTrue(Bytes.compareTo(
> Bytes.toBytes("abc\1"), scan.getStopRow()) == 0);
> > +        assertTrue(scan.getFilter() != null);
> > +    }
> > +
> > +    @Test
> > +    public void testRTrimSetScanKey() throws Exception {
> > +        String query = "SELECT inst FROM ptsdb WHERE rtrim(inst) = 'abc'";
> > +        List<Object> binds = Collections.emptyList();
> > +        Scan scan = new Scan();
> > +        compileQuery(query, binds, scan);
> > +        assertTrue(Bytes.compareTo(Bytes.toBytes("abc"), scan.getStartRow()) == 0);
> > +        assertTrue(Bytes.compareTo(Bytes.toBytes("abc\1"), scan.getStopRow()) == 0);
>
> Same here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/forcedotcom/phoenix/pull/17/files#r2837870>.
>
>



-- 
Regards
-- Tony