Great.

I'm just doing some compile testing now, but as mentioned, I've removed the
include guards and used Makefile conditionals on everything but:

 * WinEventsWayland.cpp (seems to be the convention to build all of these
with #include guards)
 * EGLNativeTypeWayland.cpp (see your comments above, also, convention)
 * TestEGLNativeTypeWayland.cpp (we need include guards to make sure that
we don't build tests that depend on weston-sdk if its not available)
 * XBMCWayland.cpp (depends on weston-sdk)

One last thing before merge - do people generally understand how this PR
works? I want to make sure that people aren't hitting the merge button if
they don't understand it because "its localized". Insufficient
documentation is a problem - I hope I've provided enough, but I might not
have.


On Fri, Oct 11, 2013 at 9:07 AM, Cory Fields <notifications@github.com>wrote:

> In xbmc/windowing/Makefile:
>
> >       WinSystem.cpp \
> >       WinEvents.cpp
> > -
> > +
> > +# Wayland implementation detail
>
> @smspillaz <https://github.com/smspillaz> EGLNativeTypeWayland.cpp needs
> a bit of fixing up as well. It tries to include the wayland headers that
> don't exist.
>
> For that particular file, I'd prefer to guard with defines rather than
> skipping the files. Otherwise I'm afraid that someone will start adding
> one-or-the-other logic in that factory eventually, rather than just
> building everything we have the headers for.
>
> With that fixed, Android builds and runs fine.
>
> After that, and the changes you're working on, i'll hit the button.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/2978/files#r6905970>
> .
>



-- 
Sam Spilsbury