On Thu, Oct 10, 2013 at 11:08 AM, Ben Noordhuis <info@bnoordhuis.nl> wrote:
> On Tue, Oct 8, 2013 at 7:21 PM, Thom Seddon <notifications@github.com> wrote:
>>
>> In lib/crypto.js:
>>
>> > @@ -383,9 +383,12 @@ Sign.prototype._write = function(chunk, encoding, callback) {
>> >  Sign.prototype.update = Hash.prototype.update;
>> >
>> >  Sign.prototype.sign = function(key, encoding) {
>> > -  encoding = encoding || exports.DEFAULT_ENCODING;
>> > -  var ret = this._binding.sign(toBuf(key));
>> > +  if (key && !key.key)
>> > +    key = { key: key };
>> > +
>> > +  var ret = this._binding.sign(toBuf(key.key), null, key.passphrase || null);
>>
>> I'm pretty sure you can't have an empty passphrase, if that's wrong I will switch it back
>
> I guess that's true for OpenSSL but I'm not 100% positive it's true
> for other crypto toolkits too.

Then again, that's immaterial because PEM_write_bio_PrivateKey() and
friends won't accept it.  Okay, no empty strings then.