before pull req
basic completed