update attributes documented and better tested2