modify pull up funciton