A fixed "1)" and "2)" and also added new test to check descriptors leak.
Check it out and lets decide on pull. _)


On Fri, Feb 1, 2013 at 1:04 AM, Christian Johansen <notifications@github.com
> wrote:

> In lib/em_pessimistic/deferrable_child_process.rb:
>
> >        else
> > -        succeed(@stdout.join.strip, status)
> > +        succeed(@stdout.join.strip, @stderr.join.strip, status)
> >        end
>
> Two problems here:
>
> 1) This changes the semantic of the library, so now some tests are failing
> (you can run them by doing rake)
> 2) When the process fails, stdout is not relevant. When the process
> succeeds, stderr is not relevant. I may be convinced that they should be
> passed anyway, but in that case I would like fail(stderr, stdout, status)and succeed(stdout,
> stderr, status) instead to emphasize what you most likely want.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cjohansen/em_pessimistic/pull/1/files#r2856822>.
>
>



-- 
*Best regards,*
*Andrey Chergik*