Misc. NaCl infobar cleanup, part 2.

* Remove unneeded member
* Remove using directives
* Shorten/simplify

BUG=none
TEST=none
R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/18340010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210692 0039d316-1c4b-4281-b951-d872f2087c98
fix loop

fix

remove

rename

fix yielding

add another expected

add expected

rem another

remove dcheck

rewrite state machine

rem unused

rem startread loop

read loop

fix test

use read

fix test

fix test

fix another staet

fix test

rem bool

initial write loop

fix var

bail out if closed

rem dcheck

fix onreadcomplete

fix loop

check state

remove availability state

clean up states

remove unused states

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210694 0039d316-1c4b-4281-b951-d872f2087c98
Revert 210694 "fix loop"

> fix loop
> 
> fix
> 
> remove
> 
> rename
> 
> fix yielding
> 
> add another expected
> 
> add expected
> 
> rem another
> 
> remove dcheck
> 
> rewrite state machine
> 
> rem unused
> 
> rem startread loop
> 
> read loop
> 
> fix test
> 
> use read
> 
> fix test
> 
> fix test
> 
> fix another staet
> 
> fix test
> 
> rem bool
> 
> initial write loop
> 
> fix var
> 
> bail out if closed
> 
> rem dcheck
> 
> fix onreadcomplete
> 
> fix loop
> 
> check state
> 
> remove availability state
> 
> clean up states
> 
> remove unused states

TBR=akalin@chromium.org

Review URL: https://codereview.chromium.org/18822006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210696 0039d316-1c4b-4281-b951-d872f2087c98
[SPDY] Clean up some SpdySession tests

(These should have been cleaned up as part of r210054, but I missed
them.)

Assert that SpdySession::InitializeWithSocket is called at most once.

Rename SpdySession::pending_session_create_queues to
pending_session_create_queue_size and make it const.

Use SpdySession::CloseSessionOnError in SpdySession tests instead of
calling into the SpdySessionPool directly; this is to prepare for
a future change where those are not necessary equivalent.

BUG=255701
R=rch@chromium.org

Review URL: https://codereview.chromium.org/18760003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210697 0039d316-1c4b-4281-b951-d872f2087c98
IndexedDB: Switch key/value handling from vector<char> to std::string

LevelDB uses std::string in its APIs. To eliminate a conversion and
simplify the code, switch the IDB backend from vector<char> to string
as well.

Also eliminate the LevelDBSlice type as well, using StringPiece
and leveldb::Slice as appropriate.

R=alecflett@chromium.org,tsepez@chromium.org
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18075008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210698 0039d316-1c4b-4281-b951-d872f2087c98
IndexedDB: ContinueFunction -> Continue

In the Blink codebase, the "IDBCursor.continue()" IDL operation was
implemented as continueFunction() to avoid the C++ keyword. Given
Chromium coding style, this can just be Continue().

R=alecflett@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18234008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210699 0039d316-1c4b-4281-b951-d872f2087c98
[Cleanup] STLDeleteContainerPointers->ScopedVector

ScopedVector makes ownership management a tiny bit easier
for vector<T*> and owned objects.

R=jochen@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18377005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210700 0039d316-1c4b-4281-b951-d872f2087c98
Media Galleries API Picasa: Put PMP parsing step into sandboxed utility process.

This changeset moves the Picasa PMP database parsing step onto the sandboxed utility process to securify the parsing of untrusted user data.

The CL is contingent on 18231002.

BUG=151701

Review URL: https://chromiumcodereview.appspot.com/18387003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210701 0039d316-1c4b-4281-b951-d872f2087c98
A few cleanup changes to the GoogleURLTracker classes:
* Fix a few incorrect comments.
* Rename "infobar" to "delegate" or "infobar delegate" in various places for
  better accuracy/clarity.
* Be more paranoid about not trying to remove an infobar after it navigates the
  current page.  I don't think this would actually cause problems since the
  infobar wouldn't normally be removed until the load commits (asynchronously),
  but the new code seems more guaranteed to be safe.

BUG=none
TEST=none
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/18209013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210702 0039d316-1c4b-4281-b951-d872f2087c98
file_manager: Add DELETED_prefix to the enum of a removed function

Forgot to do this in crrev.com/210491

BUG=256952
TEST=none
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/18039004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210703 0039d316-1c4b-4281-b951-d872f2087c98
Don't count host permission changes for v2 apps as a permission increase.

BUG=255229

Review URL: https://chromiumcodereview.appspot.com/18399007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210704 0039d316-1c4b-4281-b951-d872f2087c98
Disable texture sharing on AMD switchable via the blacklist.

Removes the previous logic that was hardcoded in the GpuDataManager and adds
a new entry to the blacklist.

BUG=258521
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/18402006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210705 0039d316-1c4b-4281-b951-d872f2087c98
[Cleanup] Factor out layout store code from DisplayController

TBR=jamescook@chromium.org
BUG=253991
TEST=no functional change. all tests should pass.

Review URL: https://chromiumcodereview.appspot.com/18413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210706 0039d316-1c4b-4281-b951-d872f2087c98
[NaCl SDK] test_sdk actually runs the tests (using browser_tester).

BUG=139415
R=noelallen@chromium.org
R=sbc@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17121010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210707 0039d316-1c4b-4281-b951-d872f2087c98
drive: Remove FileSystemInterface::GetResourceEntryById()

This function is no longer in use.

BUG=258313
TEST=none
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/18855010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210708 0039d316-1c4b-4281-b951-d872f2087c98
Disable InputVolumeTest on ARM linux.

BUG=238490

Review URL: https://chromiumcodereview.appspot.com/18209007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210709 0039d316-1c4b-4281-b951-d872f2087c98
Fix cpplint warning.

cpplint expects the closing brace of a namespace declaration to have a comment with the namespace.
A comment is missing from nacl_browser.cc and it triggers cpplint warnings.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/18428004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210710 0039d316-1c4b-4281-b951-d872f2087c98
Include the source frame number in traces.

This allows us to more easy see where the main thread frame is when
looking at traces.

R=enne, nduca
BUG=

Review URL: https://chromiumcodereview.appspot.com/18500020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210711 0039d316-1c4b-4281-b951-d872f2087c98
Register for invalidations when SyncManager exists

The SyncBackendHost forwards all invalidations directly to the
SyncManager.  This can cause problems if the SyncManager does not exist
at the time.

This CL tries to fix the problem by ensuring that the SyncBackendHost is
registered to receive invalidations only when the SyncManager actually
exists.  This makes it more difficult to know whether or not it is
necessary to unregister at shutdown, so this CL also adds a boolean flag
to track the SyncBackendHost's registration state.

BUG=256878

Review URL: https://chromiumcodereview.appspot.com/18551009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210712 0039d316-1c4b-4281-b951-d872f2087c98
cc: Remove tile ref counting in tile manager.

Instead of increasing a ref count on a tile when passing a task
into raster worker pool, use a unique id and a hash map. This allows
tiles to be deleted even when raster task is working on rasterizing
a resource.

BUG=256777

Review URL: https://chromiumcodereview.appspot.com/18581004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210713 0039d316-1c4b-4281-b951-d872f2087c98