popups fully implimented