Add extra tests for logging parameters

Signed-off-by: Ken Barber <ken@bob.sh>
Merge pull request #186 from kbarber/log_level

Add extra tests for logging parameters
Add more log param tests

Signed-off-by: Ken Barber <ken@bob.sh>
Merge pull request #187 from kbarber/log_changed_name

Add more log param tests
(#20912) Split argments while maintaining quoted strings

Github Bug: 182
Signed-off-by: Joe Julian <me@joejulian.name> (signed CLA)
Accidentally deleted the conversion to -D
Fix log test to replicate bug #182

Signed-off-by: Ken Barber <ken@bob.sh>
Merge pull request #189 from joejulian/ticket/20912-split_arguments_while_maintaining_quoted_strings

(#20912) Split argments while maintaining quoted strings
Swap log_prefix and log_level order to match the way it's saved

Fixes #184
Signed-off-by: Joe Julian <me@joejulian.name>
Merge pull request #191 from joejulian/log_level-in-wrong-order

Swap log_prefix and log_level order to match the way it's saved
Accept pre-existing rule with invalid name

This patch fixes up a pre-existing rule whose name does not
type-validate with a valid name (typically one without a numeric
prefix in the comment).

Fixes #116
Signed-off-by: Joe Julian <me@joejulian.name>
Fixed dumb logic error
Ensure all services have 'hasstatus => true' for Puppet 2.6

We were getting reports of idempotency issues with 2.6, due to missing
hasstatus setting.

Signed-off-by: Ken Barber <ken@bob.sh>
Merge pull request #192 from joejulian/116/pre-existing_rules_name_fix

Accept pre-existing rule with invalid name
Merge pull request #197 from kbarber/hasstatus

Ensure all services have 'hasstatus => true' for Puppet 2.6
Update rspec-system tests for rspec-system-puppet 1.5

Signed-off-by: Ken Barber <ken@bob.sh>
Merge pull request #199 from kbarber/rspec-system-15

Update rspec-system tests for rspec-system-puppet 1.5
Fix #188: -f in comment leads to puppet resource firewall failing.
Update tests for rspec-system-puppet 2

This changes all the tests to be not only compatible with rspec-system-puppet
2, but to use some of the new syntactic sugar it provides.

Signed-off-by: Ken Barber <ken@bob.sh>
Merge pull request #209 from kbarber/rspec-system-puppet-2

Update tests for rspec-system-puppet 2