I must have read this one wrong originally when reviewing it through my phone.  Guess the idea was to stay with the current junit.  So my pull request #4 doesn’t do much otherwise.  Any chance you can leave it out there a while or cherry pick changes from it until mule is up to latest?  I believe there are a number of things needing updated there too in order to get on the latest.

 

Thanks,

 

Jeremy Landis

 

From: Mariano Gonzalez [mailto:notifications@github.com] 
Sent: Monday, December 02, 2013 10:02 AM
To: mulesoft/mule-common; mulesoft/mule-common
Cc: Jeremy Landis; Jeremy Landis
Subject: Re: [mule-common] Project Cleanup & Dependency Update (#3)

 

In pom.xml:

> @@ -7,9 +8,12 @@
>      <description>Shared Interfaces between Studio and ESB for Metadata and Connectivity access</description>
>  
>      <properties>
> -        <antlr.version>3.5</antlr.version>
> +        <antlr.version>3.5.1</antlr.version>

Hello, I'm probably missing context on what you're doing to say if it's ok or not to change build plugin updates. That would probably require involvement from the Studio team, I suggest open a Jira to them. As for jUnit, I think that's a low risk one but I'd stay with the version Mule is using for consistency sake.

…

---------- Mariano Gonzalez Cloud Integrations Architect | Mulesoft (http://www.mulesoft.com/) Corrientes 316 Entre Piso - C1043AAQ - Buenos Aires - Argentina Tel: +54-11-5353-4497 We're Hiring! (http://www.mulesoft.com/careers) Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Monday, December 2, 2013 at 11:55 AM, Jeremy Landis wrote: In pom.xml: > @@ -7,9 +8,12 @@ > <description>Shared Interfaces between Studio and ESB for Metadata and Connectivity access</description> > > <properties> > - <antlr.version>3.5</antlr.version> > + <antlr.version>3.5.1</antlr.version> Sure thing. I have mule forked too and see the size is huge overall. Are you ok with updates to the localized build plugin updates? I assume junit being updated is slightly risky too for same reasons. What is your opinion on that? I haven't seen it cause a downstream effect yet but pull builds of mule are slow going. --- Original Message --- From: "Mariano Gonzalez" <notifications@github.com (mailto:notifications@github.com) <mailto:notifications@github.com%20(mailto:notifications@github.com)> > Sent: December 2, 2013 9:43 AM To: "mulesoft/mule-common" <mule-common@noreply.github.com (mailto:mule-common@noreply.github.com) <mailto:mule-common@noreply.github.com%20(mailto:mule-common@noreply.github.com)> > Cc: "Jeremy Landis" <jeremylandis@hotmail.com (mailto:jeremylandis@hotmail.com) <mailto:jeremylandis@hotmail.com%20(mailto:jeremylandis@hotmail.com)> > Subject: Re: [mule-common] Project Cleanup & Dependency Update (#3 <https://github.com/mulesoft/mule-common/pull/3>  (https://github.com/mulesoft/mule-common/pull/3)) @@ -7,9 +8,12 @@ <description>Shared Interfaces between Studio and ESB for Metadata and Connectivity access</description> <properties> - <antlr.version>3.5</antlr.version> + <antlr.version>3.5.1</antlr.version> The thing with updating is that any change in mule-commin spawns a testing effort in the ESB, Studio, Devkit, Connectors, etc. So, although I'm all for using the latest libraries available, such a change needs to happen with planning and involvement from the development and QA team. If you didn't find a bug that is fixed by this change then rollback this change and open a jira requesting the update … (#) --- Reply to this email directly or view it on GitHub: https://github.com/mulesoft/mule-common/pull/3/files#r8026290 — Reply to this email directly or view it on GitHub (https://github.com/mulesoft/mule-common/pull/3/files#r8026712). 

—
Reply to this email directly or view it on GitHub <https://github.com/mulesoft/mule-common/pull/3/files#r8026909> .  <https://github.com/notifications/beacon/cfbemxk8F8smNvKeAYgxsRnDq38kipfMHFGU3BFKMf4B9naz9J22nvNhK6esn80x.gif>