In theory if we want full docs we should add @access etc. too so I'm still
:+1: for full docblocks but let's see what Marc and the others think?
On 11 Nov 2013 22:55, "Nathan Guse" <notifications@github.com> wrote:

> In entity/rule.php:
>
> > +*
> > +* Schema:
> > +*	rule_id
> > +*	rule_language
> > +*	rule_left_id
> > +*	rule_right_id
> > +*	rule_anchor
> > +*	rule_title
> > +*	rule_message
> > +*	rule_message_bbcode_uid
> > +*	rule_message_bbcode_bitfield
> > +*	rule_message_bbcode_options
> > +*/
> > +class rule implements rule_interface
> > +{
> > +	/** @var array Data for this entity */
>
> I guess it might be best to do it two different ways.
>
> Perhaps for variables like this, it might be good to explain it more and
> what should be in it (e.g. the elements from the schema structure listed a
> few lines up).
>
> For variables like $db, $template, etc that are just other objects, a
> single line comment should be more than enough and not take up tons of
> extra space at the top.
>
> Sound reasonable?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/phpbb-extensions/boardrules/pull/8/files#r7576882>
> .
>