I'm just wondering if we should make this an explicit feature of ocaml-uri then -- expose a Uri_service.t that can also just be a raw port number.  

-anil

On 2 Sep 2013, at 15:08, Vincent Bernardoff <notifications@github.com> wrote:

> In lwt/cohttp_lwt.ml:
> 
> > @@ -21,7 +21,7 @@ open Lwt
> >  module type Net = sig
> >    module IO : IO.S
> >    val connect_uri : Uri.t -> (IO.ic * IO.oc) Lwt.t
> > -  val connect : ?ssl:bool -> string -> int -> (IO.ic * IO.oc) Lwt.t
> > +  val connect : ?ssl:bool -> string -> string -> (IO.ic * IO.oc) Lwt.t
> On 02/09/2013 15:24, Anil Madhavapeddy wrote: why's the port a string now? is it worth labelling these to disambiguate string -> string now?
> It is because for getaddrinfo, "port" is actually a string that can be either a service name or a port number (as a string). Is it better like that now ?
> —
> Reply to this email directly or view it on GitHub.
> 
>