On 09/10/2013 05:10 PM, Ken Steele wrote:
> In src/flow.h:
> 
>> @@ -290,7 +290,7 @@
>>       *  On receiving a packet the counter is incremented while the flow
>>       *  bucked is locked, which is also the case on timeout pruning.
>>       */
>> -    SC_ATOMIC_DECLARE(unsigned short, use_cnt);
>> +    SC_ATOMIC_DECLARE(unsigned int, use_cnt);
> 
> pahole is correct, I missed that vlanid was an array of two values.
> 
> Are these comments generated by hand or programmatically?

They are created by pahole. I ran it as:
pahole -C Flow_ src/suricata

> The cacheline boundaries are interesting, but not enforced by the
> structure alignment.

Not sure what you mean here?