Yeah, I had reservations about doing anything with that one as it is ;)
On Nov 29, 2013 4:54 PM, "Nicolas Viennot" <notifications@github.com> wrote:

> In lib/no_brainer/query_runner/database_on_demand.rb:
>
> >        # RethinkDB may return an FIND_DB not found immediately
> >        # after having created the new database, Be patient.
> >        # TODO Unit test that thing
> >        # Also, should we be counter based, or time based for the timeout ?
> > -      NoBrainer.db_create $1 unless env[:db_find_retries]
> > -      env[:db_find_retries] ||= 0
> > +      NoBrainer.db_create $1 unless retries
> > +      retries ||= 0
>
> You are breaking code here.
>
> if the method retries returns env[:db_find_retries], then if the retry
> variable is not set in env, retries will return nil.
> retries ||= 0 will have absolutely no effect since it won't be written
> back in the env.
>
> This change is not happening.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nviennot/nobrainer/pull/25/files#r8008527>
> .
>