not sure about this test ... can you add unit test for this method ?