Remove a couple more deprecated JoinDependency api

Looking into the history for ActiveRecord::Associations::JoinDependency
should give us some help on why each one of those were removed. See for
example:

https://github.com/rails/rails/commit/868457488d3c43ff4e9c28e34883620d90345185