This seems cleaner since the dialogs can be assembled in a variety of different ways. It provides a simple way of leveraging the existing handler (until we think the dialogs need to behave differently based on keyboard vs. click)

All other comments seem fine. I was expecting we'd need to expand that function to take an object soon :)

> On Nov 6, 2013, at 10:48 AM, Brandon Bloom <notifications@github.com> wrote:
> 
> In src/feedback.js:
> 
> > @@ -468,8 +473,22 @@ exports.createModalDialogWithIcon = function(Dialog, contentDiv, onHidden) {
> >    modalBody.appendChild(imageDiv);
> >    contentDiv.className += ' modal-content';
> >    modalBody.appendChild(contentDiv);
> > +  
> > +  var btn = contentDiv.querySelector(defaultBtnSelector);
> > +  var keydownHandler = function(e) {
> > +    if (e.keyCode == 13 || e.keyCode == 32) {
> > +      Blockly.fireUiEvent(btn, 'click');
> Is there a reason you're firing a click event, rather than calling some common handler function?
> 
> —
> Reply to this email directly or view it on GitHub.