The variable name you suggest is wrong, sorry.
the boolean represents that we know beforehand that there is no current
motion for the discussion. It does not mean that there is a motion and it
does not tell the partial to display the motion.. it is an optimisation
based on knowledge from a previous query.

I would recommend that if the behaviour is qa'd then you just accept the pq
without further modification. I don't think it merits it personally, and
your suggested change here would not be an improvment becuase the variable
would be less concice.

I really appreciate you verifying this and looking into it but don't put
too much time into it.. otherwise it's going to cost more that a quick fix
should.


On Mon, Aug 19, 2013 at 2:04 PM, john irving <notifications@github.com>wrote:

> In app/views/discussions/index.html.haml:
>
> > @@ -2,7 +2,7 @@
> >    #discussion-list
> >      - if @discussions.present?
> >        - @discussions.each do |discussion|
> > -        %li.selector-item= render '/discussions/discussion_preview', discussion: discussion, this_group: @group
> > +        %li.selector-item= render '/discussions/discussion_preview', discussion: discussion, this_group: @group, discussion_surely_has_no_current_motion: true
>
> The code look really good. Have discussed review with Jon, and about to QA
>
> Unless you have specific issue with it, I'm going to change:
> discussion_surely_has_no_current_motion: false
> to
> display_discussion_motion: true
>
> and invert the logic in the partial, mainly in order to make this code
> more readable.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/loomio/loomio/pull/980/files#r5833661>
> .
>