[FrameworkBundle] made sure that the debug event dispatcher is used everywhere
[Process] Fix #9343 : revert file handle usage on Windows platform
fixed typo
minor #9362 fixed typo (samsonasik)

This PR was merged into the master branch.

Discussion
----------

fixed typo

Commits
-------

98bdb5f fixed typo
Clean up of WebProfiler Controller classes:

Added missing "@throws" PHPdoc comments in controllers
Updated deprecated reference to Symfony\Component\HttpKernel\Debug\ExceptionHandler to use Symfony\Component\Debug\ExceptionHandler instead
minor #9359 Clean up of WebProfiler Controller classes (caponica)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #9359).

Discussion
----------

Clean up of WebProfiler Controller classes

 - Added missing "@throws" PHPdoc comments in controllers
 - Updated deprecated reference to Symfony\Component\HttpKernel\Debug\ExceptionHandler to use Symfony\Component\Debug\ExceptionHandler instead

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no

Commits
-------

592b831 Clean up of WebProfiler Controller classes:
Fixed English usage for existing users.
git push #9372 Fixed English usage for existing users. (mgenereu)

This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9372).

Discussion
----------

Fixed English usage for existing users.

Commits
-------

b674e44 Fixed English usage for existing users.
bug #9354 [2.2][Process] Fix #9343 : revert file handle usage on Windows platform (romainneutron)

This PR was merged into the 2.2 branch.

Discussion
----------

[2.2][Process] Fix #9343 : revert file handle usage on Windows platform

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9343
| License       | MIT

Hello,

I propose to revert the use of file handles only for `STDOUT` on Windows platform (see implementation in 2.2.6 [here](https://github.com/symfony/symfony/blob/4059720232e8c4acce6ca31627b87b904cf1aa77/src/Symfony/Component/Process/Process.php#L231-L242)).

When I decoupled pipes management from `Process` in #8924, I used file handles for both `STDOUT` and `STDERR`. This was an error as it introduced random failure in reading the handles (reported as [PHP#65650](https://bugs.php.net/bug.php?id=65650)).

Reverting to the previous implementation solves the issue. My apologies for the issues it introduced.

Versions that have been affected by the bug are 2.2.7, 2.2.8, 2.2.9, 2.3.4, 2.3.5 and 2.3.6.

Side note : I thought about testing the file handles implementation on *nix, but it fails most of the time where as Windows is okay. Unit testing on windows is okay (AbstractProcessTest::testProcessPipes tests it), but I don't provide a travis compatible test.

Commits
-------

e9dd408 [Process] Fix #9343 : revert file handle usage on Windows platform
Merge branch '2.2' into 2.3

* 2.2:
  Fixed English usage for existing users.
  [Process] Fix #9343 : revert file handle usage on Windows platform
Merge branch '2.3'

* 2.3:
  Fixed English usage for existing users.
  Clean up of WebProfiler Controller classes:
  [Process] Fix #9343 : revert file handle usage on Windows platform
prevent PHP from magically setting a 302 header, see http://www.php.net/manual/en/function.header.php
[FrameworkBundle] Only enable CSRF protection when enabled in config
feature #9252 [FrameworkBundle] Only enable CSRF protection when enabled in config (asm89)

This PR was squashed before being merged into the master branch (closes #9252).

Discussion
----------

[FrameworkBundle] Only enable CSRF protection when enabled in config

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | maybe?
| Deprecations? | no
| Tests pass?   | I hope, master was already broken here
| License       | MIT

https://github.com/symfony/symfony/commit/bf85e8365ab8aec8799c8207f32598ab09d95183 introduced new service configuration for CSRF protection in the frameworkbundle. It is always enabled even if you don't use it. Since it also depends on enabling the session that's not so nice.

Commits
-------

60dce14 [FrameworkBundle] Only enable CSRF protection when enabled in config
feature #9365 prevent PHP from magically setting a 302 header (lsmith77)

This PR was merged into the master branch.

Discussion
----------

prevent PHP from magically setting a 302 header

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes (for people relying on getting a magic 302 when setting a Location header)
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

this needs a test case .. but first let me know if you are ok with this change.
see http://www.php.net/manual/en/function.header.php

Commits
-------

c140d4f prevent PHP from magically setting a 302 header, see http://www.php.net/manual/en/function.header.php
[Form] Fixed form debugger to work even when no view variables are logged  (e.g. upon redirects)
bug #9394 [Form] Fixed form debugger to work even when no view variables are logged (bschussek)

This PR was merged into the master branch.

Discussion
----------

[Form] Fixed form debugger to work even when no view variables are logged

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9331
| License       | MIT
| Doc PR        | -

Commits
-------

99a4b7e [Form] Fixed form debugger to work even when no view variables are logged  (e.g. upon redirects)
bug #9168 [FrameworkBundle] made sure that the debug event dispatcher is used everywhere (fabpot)

This PR was merged into the master branch.

Discussion
----------

[FrameworkBundle] made sure that the debug event dispatcher is used everywhere

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6686, #7673
| License       | MIT
| Doc PR        | n/a

The removal of the Profiler dependency on the TraceableEventDispatcher (#9170) allows to remerge the patch from #9068 that fixes #6686.

This PR also cleans up how profiles are stored. A Profile is now always stored only once.

The fix will only be available on 2.4+ as the changes are too deep to be backported to 2.2 and 2.3.

Commits
-------

1e1835e [FrameworkBundle] made sure that the debug event dispatcher is used everywhere