update for sample and feature