I've changed it back to hasOwnProperty in a new changelist.


On Thu, May 23, 2013 at 9:32 AM, Dan Vanderkam <notifications@github.com>wrote:

> In auto_tests/tests/CanvasAssertions.js:
>
> > @@ -194,7 +194,8 @@ CanvasAssertions.match = function(predicate, call) {
> >      return predicate(call);
> >    } else {
> >      for (var attr in predicate) {
> > -      if (predicate.hasOwnProperty(attr) && predicate[attr] != call.properties[attr]) {
> > +      if (attr in predicate && (
>
> We won't be out of the woods on hasOwnProperty() for a long time -- not
> just until all browsers support Object.defineProperty, but also until all
> JS libraries use it.
> … <#13ed23fc70743367_>
> On Thu, May 23, 2013 at 9:06 AM, klausw-g <notifications@github.com>
> wrote: In auto_tests/tests/CanvasAssertions.js: > @@ -194,7 +194,8 @@
> CanvasAssertions.match = function(predicate, call) { > return
> predicate(call); > } else { > for (var attr in predicate) { > - if
> (predicate.hasOwnProperty(attr) && predicate[attr] !=
> call.properties[attr]) { > + if (attr in predicate && ( Also,
> http://phrogz.net/death-to-hasownproperty — Reply to this email directly
> or view it on GitHub<
> https://github.com/danvk/dygraphs/pull/248/files#r4363840> .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/danvk/dygraphs/pull/248/files#r4364329>
> .
>