some signin details finished
merge