Yeah agreed - consistency. I'm not in love with either plural or singular,
so just pick one and run!


On Tue, Dec 3, 2013 at 3:51 PM, Andrew Hayward <notifications@github.com>wrote:

> In bin/schema.sql:
>
> > +       evidence INT REFERENCES evidence(evidenceId), #not sure about this
> > +       batchName INT REFERENCES claimCodeBatch(claimCodeBatchId),
> > +       multi BOOLEAN NOT NULL,
> > +       PRIMARY KEY(claimCodeId)
> > +);
> > +
> > +DROP TABLE IF EXISTS badgeClassToTag;
> > +CREATE TABLE badgeClassToTag (
> > +       badgeToTagId INT auto_increment,
> > +       badgeClass INT NOT NULL REFERENCES badgeClass(badgeClassId),
> > +       tag INT NOT NULL REFERENCES tags(tagId),
> > +       PRIMARY KEY(badgeToTagId)
> > +);
> > +
> > +DROP TABLE IF EXISTS tags;
> > +CREATE TABLE tags (
>
> Minor point - why is this table plural? Personally, I'd prefer them all to
> be plural, but everything else is singular, so you might as well be fully
> consistent.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mozilla/openbadger/pull/323/files#r8077158>
> .
>



-- 
@chmcavoy <http://twitter.com/chmcavoy>
http://lonelylion.com