OK


On Mon, Oct 14, 2013 at 4:27 PM, Paul A Martel <notifications@github.com>wrote:

> In tests/frontend/org/voltdb/TestAdHocQueries.java:
>
> > -            catch (ProcCallException pcex) {
> > -                System.out.println("DEBUG what?" + pcex.getMessage());
> > -                assertTrue(pcex.getMessage().indexOf("not support self joins") > 0);
> > -            }
> > +//            adHocQuery = "SELECT FIRST1.EMPNUM, SECOND2.EMPNUM \n" +
> > +//                    "          FROM STAFF FIRST1, STAFF SECOND2 \n" +
> > +//                    "          WHERE FIRST1.CITY = SECOND2.CITY \n" +
> > +//                    "          AND FIRST1.EMPNUM < SECOND2.EMPNUM;";
> > +//            try {
> > +//                env.m_client.callProcedure("@AdHoc", adHocQuery);
> > +//                fail("did not fail on selfjoin");
> > +//            }
> > +//            catch (ProcCallException pcex) {
> > +//                System.out.println("DEBUG what?" + pcex.getMessage());
> > +//                assertTrue(pcex.getMessage().indexOf("not support self joins") > 0);
> > +//            }
>
> Don't use comments to delete dead code without some stated purpose for
> keeping it around.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/5/files#r6954622>
> .
>