add 1 test and 2 methods for shares