Don't load the (unused) LSB functions in the RHEL init script

The RedHat init script tried to load the LSB functions from the wrong place,
breaking the RPM packages.  When I came to fix that, it was apparent that we
don't actually *use* those functions at all.

So, this removes the attempt to load them, which trivially fixes the bug.

Closes #447.

Signed-off-by: Daniel Pittman <daniel@rimspace.net>
Don't load the (unused) LSB functions in the Debian init script

Like the RHEL changes, this stops loading the LSB functions in the Debian
init script.  Since we didn't actually use any of those capabilities, this
simplifies the script with no particular cost to us.

Signed-off-by: Daniel Pittman <daniel@rimspace.net>
Add a newline to the `--version` output

As noted in #450, `razor --version` would print the version number
without a trailing newline.  This moves from print to puts, fixing
that, and ensuring we have a pleasant CLI experience.

Closes #450.
Merge pull request #449 from daniel-pittman/bug/master/447-rpm-init-script-fail

RPM init script fails trying to load LSB functions
Eliminate commented out code from slice spec tests

There was a chunk of commented out code in the slice spec tests that,
apparently, was disabled but never removed during previous work.

This deletes that - commented lines only, so no effect beyond clearer code.

Signed-off-by: Daniel Pittman <daniel@rimspace.net>
Return the final slice name from the `slice_name` method

The previous implementation of `slice_name` was correct, in the sense that it
preserved the behaviour from the earlier implementation, but it didn't fix a
larger problem - that every consumer of that value had to manually transform
that into the actual slice name.

This fixes that, by adding tests to ensure the method does what it should, and
then replacing all those open-coded transformations with nothing but the call
to the `slice_name` method.

This closes #452.

Signed-off-by: Daniel Pittman <daniel@rimspace.net>
Merge pull request #453 from daniel-pittman/bug/master/452-slice-name-method-should-return-the-slice-name

#452: slice name method should return the slice name
(#443) Added inverse.to_s in TagRule.add_tag_matcher

This change modifies the TagRule.add_tag_matcher method to call to_s
on the inverse tag_matcher option instead of the compare option. The
reason is that inverse might be a boolean or a string whereas compare
should always be a string. The original code was the other way around,
suggesting this problem might simply be an oversight.

The reason this change is necessary is that the inverse tag_matcher option
might be a boolean. When this is the case, the TagRule.add_tag_matcher
will not add the tag_matcher and simply return false. This was rather
obscur to troubleshoot so his change also added some warning when the
tag_matcher options have unexpected values.

The change includes rspec tests for the .add_tag_matcher method in the
ProjectRazor::Tagging::TagRule class. It also includes a few require
statements so that the tests can be run only for a single file:

  rspec spec/project_razor/tagging/tag_rule_spec.rb

This pull request fixes issue #443.
Rewrite spec tests to use let methods, no member variables

This replaces the member variables and before method used in CR3's version of
the tests with `let` methods; that reduces the amount of memory tied up beyond
the scope of the individual tests[1].

It is also good practice, because it avoids any risk that member variables -
which are global state shared between test instances - can cause unexpected
behavioural dependencies between individual tests.

[1] At least some versions of rspec, and reporters, have kept the individual
    test class instances alive for the entire duration of the suite running.

    That, in turn, means that any member variable, and anything it depends on,
    lives for that same duration.

Signed-off-by: Daniel Pittman <daniel@rimspace.net>
Merge branch 'cr3-bug/master/443-inverse-tag-matcher-problems'
(packaging) Add raring to the default cows list

Raring will be released near the end of April, so this commit adds it to the
list of cows to build against.
(packaging) Remove f16 from mocks to build as it is EOL

Fedora 16 went EOL 02-12-2013, so this commit removes it from the mocks to be
built against.
Merge pull request #457 from haus/update_cows_mocks

Update cows mocks