Good catch. fixed.


On Tue, Aug 13, 2013 at 12:05 AM, timcherry <notifications@github.com>wrote:

> In kafka/zookeeper.py:
>
> > +        if self.producer_kls is None:
> > +            raise NotImplemented("Producer class needs to be mentioned")
> > +
> > +        self.zkclient = KazooClient(hosts=hosts)
> > +        self.zkclient.start()
> > +
> > +        # Start the producer instance
> > +        self.client = get_client(self.zkclient, chroot=chroot)
> > +        self.producer = self.producer_kls(self.client, topic, **kwargs)
> > +
> > +        # Stop Zookeeper
> > +        self.zkclient.stop()
> > +        self.zkclient.close()
> > +        self.zkclient = None
> > +
> > +    def stop():
>
> I think you forgot 'self' in the function prototype.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mahendra/kafka-python/pull/1/files#r5717491>
> .
>



-- 
Mahendra

http://twitter.com/mahendra