I think it is ok
On Dec 20, 2013 3:17 PM, "Jan Henning Thorsen" <notifications@github.com>
wrote:

> In lib/Convos/Core/Connection.pm:
>
> > @@ -787,6 +815,26 @@ sub cmd_join {
> >    }
> >  }
> >
> > +sub _add_convos_message {
> > +  my ($self, $data) = @_;
> > +  my $login = $self->login;
> > +  my $message;
> > +
> > +  $data->{status} ||= 200;
> > +  $data->{timestamp} ||= time;
> > +  local $data->{event} = 'message';
> > +  local $data->{host} = $self->server;
> > +  local $data->{nick} = $self->server;
> > +  local $data->{server} = 'convos'; # make sure target in js works
>
> This is sort of an ugly hack. Do you think making the shortcut will bite
> us later? At least now I didn't have to juggle too much code in the
> javascript...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Nordaaker/convos/pull/27/files#r8500028>
> .
>