Bump version to 3.99.96

Should be fairly ok now, I hope.

Signed-off-by: Andreas Ericsson <ae@op5.se>

git-svn-id: https://nagios.svn.sourceforge.net/svnroot/nagios/nagioscore/trunk@2664 5f96b256-904b-4d8d-8c98-d829582c6739
Fixed bug #432: Downtime scheduled as "Nagios Process" and not the Users name 

Previously the comment associated with a scheduled downtime would use a 
hard-coded value of "(Nagios Process)" as the user that scheduled the 
downtime. Now it will use the author from the downtime itself in the comment
associated with the downtime.

If no downtime author is specified (or more accurately, the author field in the
downtime structure is NULL), the system will default to "(Nagios Process)"
as the author of the downtime.


git-svn-id: https://nagios.svn.sourceforge.net/svnroot/nagios/nagioscore/trunk@2667 5f96b256-904b-4d8d-8c98-d829582c6739
Corrected comparison operator in service freshness check logic.

The service freshness check logic was resetting the expiration after every
short (relative to the freshness threshold) Nagios outage for service 
checks but preserving the expiration if Nagios had been down for a long 
time in comparison with the freshness threshold.

This logic was opposite the host freshness check logic, which has been correct
for quite some time.


git-svn-id: https://nagios.svn.sourceforge.net/svnroot/nagios/nagioscore/trunk@2668 5f96b256-904b-4d8d-8c98-d829582c6739
test 618cgisecurity.t: Remove semi-colons from test

We still don't match the "unlike", so I have no idea what extra
protections the semicolons add.

Signed-off-by: Andreas Ericsson <ae@op5.se>

git-svn-id: https://nagios.svn.sourceforge.net/svnroot/nagios/nagioscore/trunk@2669 5f96b256-904b-4d8d-8c98-d829582c6739
test: Remove ridonculous tests

The 620history.t and 621 extinfo.t tests only provide a html lint
scan, but relies on Test::WWW::Mechanize::CGI, which no current
distribution ships by default. Since that means it's almost certainly
too much hassle for package developers to bother with, we get rid
of them completely so we have a chance of getting people (and me) to
run 'make test' on a regular basis, since it does catch actual
errors from time to time and marks incompatibilities when they're
introduced.

Signed-off-by: Andreas Ericsson <ae@op5.se>

git-svn-id: https://nagios.svn.sourceforge.net/svnroot/nagios/nagioscore/trunk@2670 5f96b256-904b-4d8d-8c98-d829582c6739
lib/kvvec.h: Add missing declaration for kvvec_free_kvpairs()

It's a public function according to its definition, so make sure
it's usable from elsewhere too.

Signed-off-by: Andreas Ericsson <ae@op5.se>

git-svn-id: https://nagios.svn.sourceforge.net/svnroot/nagios/nagioscore/trunk@2671 5f96b256-904b-4d8d-8c98-d829582c6739
cgi: Janitor patch. Remove set-but-unused variables

We don't need them, so byebye.

Signed-off-by: Andreas Ericsson <ae@op5.se>

git-svn-id: https://nagios.svn.sourceforge.net/svnroot/nagios/nagioscore/trunk@2672 5f96b256-904b-4d8d-8c98-d829582c6739
Let cgi's use object pointers too

It's costly and inefficient to use two separate object layouts
depending on whether we're building for cgi's or the daemon, and
especially so when the separate object layouts means we require a
lot of extra code to provide the same functionality to both parts,
except one codepath is slower than the other.

With this patch we streamline the objects and let the cgi's use
object pointers the same way the core does when looking up members
and whatnot.

Signed-off-by: Andreas Ericsson <ae@op5.se>

git-svn-id: https://nagios.svn.sourceforge.net/svnroot/nagios/nagioscore/trunk@2673 5f96b256-904b-4d8d-8c98-d829582c6739