Take a look at f6c1e25 to make sure I capture the intent.


On Tue, Jul 16, 2013 at 4:31 PM, Logan Linn <notifications@github.com>wrote:

> In test/poky/kv/jdbc/util_test.clj:
>
> > +
> > +      (facts "modified_at"
> > +        (let [key1-ts (-> (jdbc-get @@S bucket "key1") :modified_at)
> > +              key1-ts-invalid (java.sql.Timestamp. (+ (.getTime key1-ts) 36000))
> > +              key2-ts (-> (jdbc-get @@S bucket "key2") :modified_at)]
> > +          (fact "valid"
> > +            (jdbc-mget @@S bucket [{:key "key1" :modified_at key1-ts}]) => (just (contains {:key "key1"})))
> > +          (fact "invalid"
> > +            (jdbc-mget @@S bucket [{:key "key1" :modified_at key1-ts-invalid}]) => empty?)
> > +          (fact "invalid + valid"
> > +            (jdbc-mget @@S bucket [{:key "key1" :modified_at key1-ts-invalid}
> > +                                   {:key "key2" :modified_at key2-ts}]) => (just (contains {:key "key2"})))))))
> > +
> > +    (facts :integration :jdbc-mset
> > +      (fact "single set"
> > +        (jdbc-mset @@S bucket [{:key "key1" :data "data1"}]) => (just "inserted"))
>
> Good find... I wonder, if there's a second nested fact, if it still fails.
>
> To fix, it should remove passing bucket as 2nd argument and add :bucket
> bucket as entry of map w/ key & data
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/drsnyder/poky/pull/16/files#r5231430>
> .
>



-- 
http://damonsnyder.net