I'd prefer onFailure(Throwable) as that's more typical w/ callbacks.  I'd
not wrap anything.


On Wed, Sep 18, 2013 at 2:47 AM, allenxwang <notifications@github.com>wrote:

> In
> ribbon-core/src/main/java/com/netflix/client/AsyncLoadBalancingClient.java:
>
> > +                                + request.getUri() + ":" +  getDeepestCause(e).getMessage(), e));
> > +                    }
> > +                    logger.error("Exception while executing request which is deemed retry-able, retrying ..., Next Server Retry Attempt#:"
> > +                            + retries
> > +                            + ", URI tried:"
> > +                            + request.getUri());
> > +                    try {
> > +                        asyncExecuteOnSingleServer(computeFinalUriWithLoadBalancer(request), this);
> > +                    } catch (ClientException e1) {
> > +                        callback.onException(e1);
> > +                    }
> > +                } else {
> > +                    if (e instanceof ClientException) {
> > +                        callback.onException(e);
> > +                    } else {
> > +                        callback.onException(new ClientException(
>
> good catch. We could wrap all Throwable with ClientException and change
> the callback interface to to onException(ClientException). The drawback is
> client may have always do getCause() to see the root cause. Any thoughts?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Netflix/ribbon/pull/46/files#r6422677>
> .
>