any reason not to use revisions.sort(key=...) here?