Oh, shoot! Nice catch. Also, reproducible oversight :-P

That expectation vacuously applied, so the tests were still successful, but it's unnecessary additional code, so good call on removing it. That change has been pushed.

On Mar 29, 2013, at 1:47 PM, Garth Webb <notifications@github.com> wrote:

> In extensions/wikia/Search/classes/Test/Controller/SearchControllerTest.php:
> 
> > +			->will		( $this->returnValue( null ) )
> > +		;
> > +		try {
> > +			$mockController->searchVideosByTitle();
> > +		} catch ( \Exception $e ) {}
> > +		$this->assertInstanceOf(
> > +				'Exception',
> > +				$e
> > +		);
> > +		$mockController
> > +			->expects	( $this->at( 0 ) )
> > +			->method	( 'getVal' )
> > +			->with		( 'title' )
> > +			->will		( $this->returnValue( 'title' ) )
> > +		;
> > +		$mockController
> I'm not referring to the try catch block here. If I copy lines 1561-1566 and paste it into the search box on my browser, I get two chunks of code highlighted:
> 
> http://screencast.com/t/TPWuPiffr
> 
> —
> Reply to this email directly or view it on GitHub.
>