SNMP/VACM: bugfix for vacmViewTreeFamilyMask

Dear all,

it's almost a year since I sent the patch attached to this e-mail, and I
just found out that I have not yet gotten a response to it.

I would consider this patch important because it fixes an issue with the
interpretation of data that might be critical for SNMPv3 operation. I
confirmed at that time that erlangs interpretation of
vacmViewTreeFamilyMask is indeed not interoperable with other SNMP
stacks.

Kind regards,

> > > the implementation of SNMP-VIEW-BASED-ACM.mib assumes that the input for
> > > vacmViewTreeFamilyMask is an OID consisting of 1's and 0's only to form
> > > the mask. However, the MIB states that the input should be a bitstring.
> > >
> > > The OID representation of the mask is useful in the code as it speeds up
> > > time-critical code paths when checking access permissions for EACH SNMP
> > > access. Reading/writing the view mask objects is less time-critical.
> > >
> > > Therefore, to fix the issue, convert between OID representation and
> > > bitstring when the vacmViewTreeFamilyMask objects are accessed. This is
> > > done by the patch attached to this e-mail.
>
>
> I'm very sorry for the troubles that I am causing but it seems that the
> previous version of the patch did more than it should: the OID-bitstring
> conversion was also applied to other tables in the same MIB on
> get/get-next requests.
>
> The version of the patch that is attached to this e-mail restricts the
> OID-bitstring conversion to vacmViewTreeFamilyMask alone.

--
Dr. Stefan Zegenhagen

arcutronix GmbH
Garbsener Landstr. 10
30419 Hannover
Germany

Tel:   +49 511 277-2734
Fax:   +49 511 277-2709
Email: stefan.zegenhagen@arcutronix.com
Web:   www.arcutronix.com

*Synchronize the Ethernet*

General Managers: Dipl. Ing. Juergen Schroeder, Dr. Josef Gfrerer -
Legal Form: GmbH, Registered office: Hannover, HRB 202442, Amtsgericht
Hannover; Ust-Id: DE257551767.

Please consider the environment before printing this message.

>From aa2acfb8a0b5ae05fc5ba982d78ee5607384a2be Mon Sep 17 00:00:00 2001
From: Stefan Zegenhagen <stefan.zegenhagen@arcutronix.com>
Date: Wed, 1 Aug 2012 09:56:15 +0200
Subject: [PATCH] bugfix for vacmViewTreeFamilyMask

The vacmViewTreeFamilyMask is defined to be a bit string in the MIB, not
an OID. However, the MIB implementation assumed the latter, effectively
rendering all attempts to read/set masks via SNMP unsuccessful.

Since the mask is used in hot paths (e.g. access permission checks for
each SNMP operation, the OID representation of the mask has benefits
(e.g. faster processing). Therefore, convert the bitstring to/from its
OID representation when reading/setting any mask object.
Merge branch 'sze/fix-vacm' into bmk/snmp/agent/fix_vacm_mask/OTP-11177
[snmp/agent] Local DB counter increment wrap error

The counter increment function in the local-db was incorrect.
It did not handle counter wrap correctly.

OTP-11192
[snmp/agent] Cleanup, renaming, appup, proper version and release notes

Add utility functions for checking view masks.
Code cleanup, function renaming and comment fix (%% instead of %).
Also updated the mask check in the vacm config file check function.
Finally, release notes and some cosmetic changes to the agent
config-file(s) user guide chapter.
Merge branch 'bmk/snmp/agent/fix_vacm_mask/OTP-11177' into bmk/snmp/snmp4241_integration/r16
Merge branch 'bmk/snmp/agent/ldb_counter_wrap/OTP-11192' into bmk/snmp/snmp4241_integration/r16

Conflicts:
	lib/snmp/doc/src/notes.xml
	lib/snmp/src/app/snmp.appup.src
Merge branch 'bmk/snmp/snmp4241_integration/r16' into maint-r16

* bmk/snmp/snmp4241_integration/r16:
  [snmp/agent] Cleanup, renaming, appup, proper version and release notes
  [snmp/agent] Local DB counter increment wrap error
  SNMP/VACM: bugfix for vacmViewTreeFamilyMask
Add missing brackets to report formatting on ftp_progress process exit

When progress reporting process exits, ftp client crashes
because of missing brackets in io_lib:format argument.
Conditionally skip process_SUITE tests that consume large amount of memory
Fix 'no previous prototype' warning for dtrace functions
Fix ‘ethr_native_rwlock_destroy’ defined but not used warning
Fix variable ‘rp_had_locks’ set but not used warning
erts: Add cflags, ldflags and config.h into executable
Add erts app-file
Fix tests for erts app-file
Refactor away ?line macro in code_SUITE
Merge branch 'aw/fix-ftp-report-formatting/OTP-11202' into maint

* aw/fix-ftp-report-formatting/OTP-11202:
  Add missing brackets to report formatting on ftp_progress process exit
Merge branch 'maint'
Fix configure detection of ethread native atomics on powerpc
Merge branch 'rickard/info/OTP-11196' into maint

* rickard/info/OTP-11196:
  Fix configure detection of ethread native atomics on powerpc