[ticket/11314] Cleanup core.js coding

function errorHandler() was used in returnHandler() before it was defined.
The unused variable alert has been removed from errorHandler(). Overuse of
the var keyword for the variable sign has been removed and the if
statement has been simplified. The definition of the variable i has been
moved outside of the for loop definition. The var keyword shouldn't be
used inside the definition of the for loop.

PHPBB3-11314
[ticket/11314] Add missing semi-colons

Omitting the semi-colon is not legal behavior for JavaScript.

PHPBB3-11314
[ticket/11314] Use return variable instead of overusing the return keyword

Use a return variable and modify it to our needs.

PHPBB3-11314
[ticket/11314] Add missing "use strict" to timezone.js files

PHPBB3-11314
[ticket/11314] Fix whitespace issues

PHPBB3-11314
[ticket/11314] Add missing radix parameters

PHPBB3-11314
Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11314
[ticket/11387] Log module added only after it has been added

PHPBB3-11387
[ticket/11404] Return empty array of avatar data if $row is empty

While creating a group in the acp, the group data ($group_row) is empty.
Due to that array_combine in phpbb_avatar_manager::clean_row() will cause
PHP Warnings. In addition to that the required indexes 'avatar',
'avatar_width', 'avatar_height', and 'avatar_type' won't be defined. This
patch will solve that issue.

PHPBB3-11404
[ticket/11404] Use a default data row if $row is empty in clean_row()

A statically defined $default_row will be used inside the
phpbb_avatar_manager::clean_row() method if the $row passed to it is
empty.

PHPBB3-11404
[ticket/11422] Increment assets when database_update is complete

PHPBB3-11422
[ticket/11404] Convert manager_test to UNIX line endings

PHPBB3-11404
[ticket/11404] Add tests for phpbb_avatar_manager::clean_row()

PHPBB3-11404
[ticket/11404] Remove version ID from manager_test.php file header

PHPBB3-11404
[ticket/11106] Undefined index EDITED_TIME_TOTAL notice.

When viewing a private message, when message edit count is 1
Undefined index EDITED_TIME_TOTAL php notice appears. Changed
the message formatting method to what is used in viewtopic.php.

PHPBB3-11106
[ticket/11433] Rename CSS class "jalert" to "phpbb_alert"

This missing change caused the loading info to appear during ajax
requests. With this patch it will be properly hidden as it should.

PHPBB3-11433
[ticket/11310] Add hashes to action links to prevent CSRF attacks

PHPBB3-11310
Merge remote-tracking branch 'remotes/nickv/ticket/11310' into develop

# By Joas Schilling
# Via Joas Schilling
* remotes/nickv/ticket/11310:
  [ticket/11310] Add hashes to action links to prevent CSRF attacks
Merge remote-tracking branch 'remotes/Marc/ticket/11433' into develop

# By Marc Alexander
# Via Marc Alexander
* remotes/Marc/ticket/11433:
  [ticket/11433] Rename CSS class "jalert" to "phpbb_alert"
Merge remote-tracking branch 'remotes/Marc/ticket/11404' into develop

# By Marc Alexander
# Via Marc Alexander
* remotes/Marc/ticket/11404:
  [ticket/11404] Remove version ID from manager_test.php file header
  [ticket/11404] Add tests for phpbb_avatar_manager::clean_row()
  [ticket/11404] Convert manager_test to UNIX line endings
  [ticket/11404] Use a default data row if $row is empty in clean_row()
  [ticket/11404] Return empty array of avatar data if $row is empty