Um…. huh.  On the face of it, that does seem odd.  And there's another one of those a few lines up.  Let me look into it.  It could be that it hasn't been a problem empirically bc/ our images are typically square…

On Jan 6, 2013, at 12:33 PM, Barnaby Rowe <notifications@github.com> wrote:

> In src/hsm/PSFCorr.cpp:
> 
> >          Minvf_xx =  Mfyy/detMf;
> >          Minvf_xy = -Mfxy/detMf;
> >          Minvf_yy =  Mfxx/detMf;
> >          sum = 0.;
> > -        for(x=fgauss.xmin;x<=fgauss.xmax;x++) {
> > -            for(y=fgauss.ymin;y<=fgauss.ymax;y++) {
> > -                dx = x - *x0_gal + *x0_psf;
> > -                dy = y - *y0_gal + *x0_psf;
> > -                sum += fgauss.image[x][y] = 
> > +        Bounds<int> fgauss_bounds(fgauss_xmin, fgauss_xmax, fgauss_ymin, fgauss_ymax);
> > +        Image<double> fgauss(fgauss_bounds);
> > +        for(int y=fgauss.getYMin();y<=fgauss.getYMax();y++) {
> > +            for(int x=fgauss.getXMin();x<=fgauss.getXMax();x++) {
> > +                dx = x - x0_gal + x0_psf;
> > +                dy = y - y0_gal + x0_psf;
> this x0_psf seems a bit suspicious, is it right? Just wanted to check, I know this code is pretty mature!
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 


-------------------------------

Rachel Mandelbaum
rmandelb@andrew.cmu.edu
http://www.andrew.cmu.edu/~rmandelb/