Fine with me.

How do we proceed on the pull request?

Who should do what?

On Fri, Jan 4, 2013 at 4:23 PM, Julien Ammous <notifications@github.com>wrote:

> In lib/em-zeromq/socket.rb:
>
> > @@ -21,8 +21,8 @@ def self.map_sockopt(opt, name)
> >          define_method("#{name}="){|val| @socket.setsockopt(opt, val) }
> >        end
> >
> > -      map_sockopt(ZMQ::HWM, :hwm)
> > -      map_sockopt(ZMQ::SWAP, :swap)
> > +      map_sockopt(ZMQ::HWM, :hwm) if defined?(ZMQ::HWM)
>
> if we keep them yes it looks like the most sensible way to ease the
> migration.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/andrewvc/em-zeromq/pull/21/files#r2550484>.
>
>