Web Inspector: Column Breakpoint not working, may be off by 1
https://bugs.webkit.org/show_bug.cgi?id=120334

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-08-27
Reviewed by David Kilzer.

Source/WebCore:

JavaScriptCore changed to 1-based column numbers at some point. We
need to update the ScriptDebugger assumption that they were 0-based.

Test: inspector-protocol/debugger/column-breakpoint.html

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::createCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):

LayoutTests:

Write a protocol test for setting a breakpoint at a line:column.

* inspector-protocol/debugger/column-breakpoint-expected.txt: Added.
* inspector-protocol/debugger/column-breakpoint.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove branch from DescendantIteratorAdapter::begin() when invoking for ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=120358

Reviewed by Andreas Kling.

* dom/ContainerNode.h:
        
    Delete isContainerNode() so it can't be called if there is static knowledge that the object is a ContainerNode.

* dom/DescendantIterator.h:
(WebCore::::DescendantIterator):

    Make DescendantIterator use Node* as root instead of ContainerNode*. It is only used for equality comparison.

(WebCore::::begin):
        
    Remove branch. Rely on ElementTraversal specialization for ContainerNodes.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[gstreamer] Make sure gstreamer source element is thread-safe
https://bugs.webkit.org/show_bug.cgi?id=115352

Patch by Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk> on 2013-08-27
Reviewed by Philippe Normand.

Source/WebCore:

GStreamer source element may be created by any gstreamer element on any thread by calling
gst_element_make_from_uri with the URIs handled by the source element.
This patch makes sure the gstreamer source element is thread-safe to avoid issues with it
being created outside the main thread.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(webKitWebSrcDispose):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(removeTimeoutSources):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::createReadBuffer):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(StreamingClient::handleNotifyFinished):
(CachedResourceStreamingClient::CachedResourceStreamingClient):
(CachedResourceStreamingClient::~CachedResourceStreamingClient):
(CachedResourceStreamingClient::loadFailed):
(CachedResourceStreamingClient::setDefersLoading):
(CachedResourceStreamingClient::getOrCreateReadBuffer):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::dataReceived):
(CachedResourceStreamingClient::notifyFinished):
(ResourceHandleStreamingClient::ResourceHandleStreamingClient):
(ResourceHandleStreamingClient::~ResourceHandleStreamingClient):
(ResourceHandleStreamingClient::loadFailed):
(ResourceHandleStreamingClient::setDefersLoading):
(ResourceHandleStreamingClient::getOrCreateReadBuffer):
(ResourceHandleStreamingClient::willSendRequest):
(ResourceHandleStreamingClient::didReceiveResponse):
(ResourceHandleStreamingClient::didReceiveData):
(ResourceHandleStreamingClient::didFinishLoading):
(ResourceHandleStreamingClient::didFail):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):
Make element thread-safe, add support to use the element without a player associated (e.g.
the DASH plugin using the webkitsrc to download fragments), use GMutexLocker to simplify
locks and other general improvements.

Source/WTF:

Add convenience class that simplifies locking and unlocking a GMutex.

* GNUmakefile.list.am:
* wtf/gobject/GMutexLocker.h: Added.
(WebCore::GMutexLocker::GMutexLocker):
(WebCore::GMutexLocker::~GMutexLocker):
(WebCore::GMutexLocker::lock):
(WebCore::GMutexLocker::unlock):
(WebCore::GMutexLocker::mutex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Added new accessibility expectations after r154332
https://bugs.webkit.org/show_bug.cgi?id=120359

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-08-27

* platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt: Added.
* platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
HTMLAppletElement: Use child iterator to walk <param> children.
<https://webkit.org/b/120361>

Reviewed by Antti Koivisto.

Take Antti's fancy new child iterator for a quick spin.

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::updateWidget):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
RenderView::flowThreadController() should return a reference.
<https://webkit.org/b/120363>

Reviewed by Antti Koivisto.

This function does lazy construction and always returns an object.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Delete unnecessary empty directory.
Unreviewed gardening.

* platform/qt-5.0-wk2/tables: Removed.
* platform/qt-5.0-wk2/tables/layering: Removed.
* platform/qt-5.0-wk2/tables/mozilla: Removed.
* platform/qt-5.0-wk2/tables/mozilla/bugs: Removed.
* platform/qt-5.0-wk2/tables/mozilla/collapsing_borders: Removed.
* platform/qt-5.0-wk2/tables/mozilla/core: Removed.
* platform/qt-5.0-wk2/tables/mozilla/dom: Removed.
* platform/qt-5.0-wk2/tables/mozilla/marvin: Removed.
* platform/qt-5.0-wk2/tables/mozilla/other: Removed.
* platform/qt-5.0-wk2/tables/mozilla_expected_failures: Removed.
* platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs: Removed.
* platform/qt-5.0-wk2/tables/mozilla_expected_failures/collapsing_borders: Removed.
* platform/qt-5.0-wk2/tables/mozilla_expected_failures/core: Removed.
* platform/qt-5.0-wk2/tables/mozilla_expected_failures/dom: Removed.
* platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin: Removed.
* platform/qt-5.0-wk2/tables/mozilla_expected_failures/other: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Simplify some more Settings access where we have a Frame in reach.
<https://webkit.org/b/120256>

Reviewed by Darin Adler.

RenderObjects can always find Settings through the Frame.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
RenderView::availableLogicalHeight() should be self-contained.
<https://webkit.org/b/120356>

Reviewed by Antti Koivisto.

Instead of checking isRenderView() in RenderBox::availableLogicalHeightUsing()
and doing an early return, do everything needed without leaving RenderView instead.
Document style never has min-/max-height so there's no need to apply constraints.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::availableLogicalHeightUsing):
* rendering/RenderView.cpp:
(WebCore::RenderView::availableLogicalHeight):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix Qt build.

* rendering/svg/RenderSVGResourceFilter.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Clumsily fix Gtk+ build. Not my proudest moment.

* rendering/svg/RenderSVGResourceFilter.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Windows] some track language tags are not recognized
https://bugs.webkit.org/show_bug.cgi?id=120335

Reviewed by Eric Carlson.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Revise implementation
to match logic in platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjc.mm


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Windows] Correct method call for characteristic update.

Reviewed by Eric Carlson.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
[Windows] Correct method call (should have been "characteristicsChanged", not
"player()->characteristicChanged()"



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154694 268f45cc-cd09-0410-ab3c-d52691b4dbfc